Add and apply rubocop rules for empty lines

We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
Javi Martín
2019-10-24 15:48:37 +02:00
parent b6750e8f17
commit db97f9d08c
585 changed files with 24 additions and 1645 deletions

View File

@@ -11,7 +11,6 @@ describe "Votes" do
before { login_as(verified) }
scenario "Index shows user votes on debates" do
debate1 = create(:debate)
debate2 = create(:debate)
debate3 = create(:debate)
@@ -60,7 +59,6 @@ describe "Votes" do
end
describe "Single debate" do
scenario "Show no votes" do
visit debate_path(create(:debate))
@@ -164,7 +162,6 @@ describe "Votes" do
visit debates_path
within("#debates") do
find(".in-favor a").click
within(".in-favor") do
@@ -363,5 +360,4 @@ describe "Votes" do
expect_message_only_verified_can_vote_proposals
end
end
end