Add and apply rubocop rules for empty lines

We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
Javi Martín
2019-10-24 15:48:37 +02:00
parent b6750e8f17
commit db97f9d08c
585 changed files with 24 additions and 1645 deletions

View File

@@ -1,7 +1,6 @@
require "rails_helper"
describe "Cards" do
before do
admin = create(:administrator).user
login_as(admin)
@@ -109,7 +108,6 @@ describe "Cards" do
end
context "Header Card" do
scenario "Create" do
visit admin_homepage_path
click_link "Create header"
@@ -219,9 +217,7 @@ describe "Cards" do
expect(page).to have_current_path admin_site_customization_page_cards_path(custom_page)
expect(page).not_to have_content "Card title"
end
end
end
pending "add image expectactions"