Add and apply rubocop rules for empty lines

We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
Javi Martín
2019-10-24 15:48:37 +02:00
parent b6750e8f17
commit db97f9d08c
585 changed files with 24 additions and 1645 deletions

View File

@@ -1,7 +1,6 @@
require "rails_helper"
describe "Stats" do
before do
admin = create(:administrator)
login_as(admin.user)
@@ -9,7 +8,6 @@ describe "Stats" do
end
context "Summary" do
scenario "General" do
create(:debate)
2.times { create(:proposal) }
@@ -36,11 +34,9 @@ describe "Stats" do
expect(page).to have_content "Comment votes 3"
expect(page).to have_content "Total votes 6"
end
end
context "Users" do
scenario "Summary" do
1.times { create(:user, :level_three) }
2.times { create(:user, :level_two) }
@@ -94,11 +90,9 @@ describe "Stats" do
expect(page).to have_content "Level two users 1"
end
end
describe "Budget investments" do
context "Supporting phase" do
let(:budget) { create(:budget) }
let(:group_all_city) { create(:budget_group, budget: budget) }
@@ -224,11 +218,9 @@ describe "Stats" do
expect(page).to have_content "Participants 2"
end
end
end
context "graphs" do
scenario "event graphs", :js do
campaign = create(:campaign)
@@ -245,11 +237,9 @@ describe "Stats" do
expect(page).to have_content event_created_at.strftime("%Y-%m-%d")
end
end
end
context "Proposal notifications" do
scenario "Summary stats" do
proposal = create(:proposal)
@@ -296,11 +286,9 @@ describe "Stats" do
expect(page).to have_content proposal_notification.body
expect(page).to have_content "Proposal not available"
end
end
context "Direct messages" do
scenario "Summary stats" do
sender = create(:user, :level_two)
@@ -319,11 +307,9 @@ describe "Stats" do
expect(page).to have_content "2"
end
end
end
context "Polls" do
scenario "Total participants by origin" do
create(:poll_officer_assignment)
3.times { create(:poll_voter, origin: "web") }
@@ -369,7 +355,6 @@ describe "Stats" do
end
within("#polls") do
within("#poll_#{poll1.id}") do
expect(page).to have_content "1"
end
@@ -377,7 +362,6 @@ describe "Stats" do
within("#poll_#{poll2.id}") do
expect(page).to have_content "2"
end
end
end
@@ -412,7 +396,5 @@ describe "Stats" do
expect(page).to have_content "2"
end
end
end
end