Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
@@ -1,7 +1,6 @@
|
||||
require "rails_helper"
|
||||
|
||||
describe "Admin legislation questions" do
|
||||
|
||||
before do
|
||||
admin = create(:administrator)
|
||||
login_as(admin.user)
|
||||
@@ -10,7 +9,6 @@ describe "Admin legislation questions" do
|
||||
let!(:process) { create(:legislation_process, title: "An example legislation process") }
|
||||
|
||||
context "Feature flag" do
|
||||
|
||||
before do
|
||||
Setting["process.legislation"] = nil
|
||||
end
|
||||
@@ -18,11 +16,9 @@ describe "Admin legislation questions" do
|
||||
scenario "Disabled with a feature flag" do
|
||||
expect { visit admin_legislation_process_questions_path(process) }.to raise_exception(FeatureFlags::FeatureDisabled)
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
context "Index" do
|
||||
|
||||
scenario "Displaying legislation process questions" do
|
||||
create(:legislation_question, process: process, title: "Question 1")
|
||||
create(:legislation_question, process: process, title: "Question 2")
|
||||
|
||||
Reference in New Issue
Block a user