Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
@@ -104,7 +104,6 @@ describe "Account" do
|
||||
end
|
||||
|
||||
context "Option to display badge for official position" do
|
||||
|
||||
scenario "Users with official position of level 1" do
|
||||
official_user = create(:user, official_level: 1)
|
||||
|
||||
@@ -133,7 +132,6 @@ describe "Account" do
|
||||
|
||||
expect(page).not_to have_css "#account_official_position_badge"
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
scenario "Errors on edit" do
|
||||
@@ -208,6 +206,5 @@ describe "Account" do
|
||||
expect(user.recommended_debates).to be(false)
|
||||
expect(user.recommended_proposals).to be(false)
|
||||
end
|
||||
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user