Add and apply rubocop rules for empty lines
We were very inconsistent regarding these rules. Personally I prefer no empty lines around blocks, clases, etc... as recommended by the Ruby style guide [1], and they're the default values in rubocop, so those are the settings I'm applying. The exception is the `private` access modifier, since we were leaving empty lines around it most of the time. That's the default rubocop rule as well. Personally I don't have a strong preference about this one. [1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
@@ -1,9 +1,7 @@
|
||||
require "rails_helper"
|
||||
|
||||
describe Management::BaseController do
|
||||
|
||||
describe "managed_user" do
|
||||
|
||||
it "returns existent user with session document info if present" do
|
||||
session[:document_type] = "1"
|
||||
session[:document_number] = "333333333E"
|
||||
@@ -23,5 +21,4 @@ describe Management::BaseController do
|
||||
expect(managed_user.document_number).to eq "333333333E"
|
||||
end
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
@@ -1,9 +1,7 @@
|
||||
require "rails_helper"
|
||||
|
||||
describe Management::SessionsController do
|
||||
|
||||
describe "Sign in" do
|
||||
|
||||
it "denies access if wrong manager credentials" do
|
||||
allow_any_instance_of(ManagerAuthenticator).to receive(:auth).and_return(false)
|
||||
get :create, params: { login: "nonexistent", clave_usuario: "wrong" }
|
||||
@@ -66,5 +64,4 @@ describe Management::SessionsController do
|
||||
expect(response).to be_redirect
|
||||
end
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
@@ -1,7 +1,6 @@
|
||||
require "rails_helper"
|
||||
|
||||
describe Management::UsersController do
|
||||
|
||||
describe "logout" do
|
||||
it "removes user data from the session" do
|
||||
session[:manager] = { user_key: "31415926", date: "20151031135905", login: "JJB033" }
|
||||
@@ -16,5 +15,4 @@ describe Management::UsersController do
|
||||
expect(response).to be_redirect
|
||||
end
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user