Add and apply rubocop rules for empty lines

We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
Javi Martín
2019-10-24 15:48:37 +02:00
parent b6750e8f17
commit db97f9d08c
585 changed files with 24 additions and 1645 deletions

View File

@@ -4,7 +4,6 @@ require "cgi"
require "json"
class RemoteTranslations::Microsoft::AvailableLocales
def self.available_locales
daily_cache("locales") do
remote_available_locales.map { |locale| locale.first }
@@ -51,5 +50,4 @@ class RemoteTranslations::Microsoft::AvailableLocales
def self.daily_cache(key, &block)
Rails.cache.fetch("remote_available_locales/#{Time.current.strftime("%Y-%m-%d")}/#{key}", &block)
end
end

View File

@@ -77,5 +77,4 @@ class RemoteTranslations::Microsoft::Client
def notranslate?(text)
text.downcase == PREVENTING_TRANSLATION_KEY
end
end

View File

@@ -1,5 +1,4 @@
module RemoteTranslations::Microsoft::SentencesParser
def detect_split_position(text)
limit = RemoteTranslations::Microsoft::Client::CHARACTERS_LIMIT_PER_REQUEST
minimum_valid_index = text.size - limit
@@ -21,5 +20,4 @@ module RemoteTranslations::Microsoft::SentencesParser
def characters_count(texts)
texts.map(&:size).reduce(:+)
end
end