Add and apply rubocop rules for empty lines

We were very inconsistent regarding these rules.

Personally I prefer no empty lines around blocks, clases, etc... as
recommended by the Ruby style guide [1], and they're the default values
in rubocop, so those are the settings I'm applying.

The exception is the `private` access modifier, since we were leaving
empty lines around it most of the time. That's the default rubocop rule
as well. Personally I don't have a strong preference about this one.


[1] https://rubystyle.guide/#empty-lines-around-bodies
This commit is contained in:
Javi Martín
2019-10-24 15:48:37 +02:00
parent b6750e8f17
commit db97f9d08c
585 changed files with 24 additions and 1645 deletions

View File

@@ -31,5 +31,4 @@ class Admin::Poll::ActivePollsController < Admin::Poll::BaseController
def active_poll_params
params.require(:active_poll).permit(translation_params(ActivePoll))
end
end

View File

@@ -6,5 +6,4 @@ class Admin::Poll::BaseController < Admin::BaseController
def namespace
"admin"
end
end

View File

@@ -1,5 +1,4 @@
class Admin::Poll::BoothAssignmentsController < Admin::Poll::BaseController
before_action :load_poll, except: [:create, :destroy]
def index
@@ -74,5 +73,4 @@ class Admin::Poll::BoothAssignmentsController < Admin::Poll::BaseController
def load_search
@search = search_params[:search]
end
end

View File

@@ -41,5 +41,4 @@ class Admin::Poll::BoothsController < Admin::Poll::BaseController
def booth_params
params.require(:poll_booth).permit(:name, :location)
end
end

View File

@@ -1,5 +1,4 @@
class Admin::Poll::OfficerAssignmentsController < Admin::Poll::BaseController
before_action :load_poll
before_action :redirect_if_blank_required_params, only: [:by_officer]
before_action :load_booth_assignment, only: [:create]
@@ -66,5 +65,4 @@ class Admin::Poll::OfficerAssignmentsController < Admin::Poll::BaseController
def load_search
@search = search_params[:search]
end
end

View File

@@ -29,5 +29,4 @@ class Admin::Poll::OfficersController < Admin::Poll::BaseController
@officer.destroy!
redirect_to admin_officers_path
end
end

View File

@@ -1,5 +1,4 @@
class Admin::Poll::ShiftsController < Admin::Poll::BaseController
before_action :load_booth
before_action :load_officer