From db4451c7c2a2d5c1cbd45a5fd1e6bc3a8c7e4947 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 10 Aug 2021 00:18:32 +0200 Subject: [PATCH] Add Performance/BlockGivenWithExplicitBlock rule We don't need to use `block_given?` since we specifically pass the block parameter, particularly since we added the Style/ExplicitBlockArgument rule in commit a102f3f0a. --- .rubocop.yml | 3 +++ app/components/concerns/header.rb | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index e9548346f..367a8dde3 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -205,6 +205,9 @@ Lint/UselessAssignment: Lint/Void: Enabled: true +Performance/BlockGivenWithExplicitBlock: + Enabled: true + Performance/CompareWithBlock: Enabled: true diff --git a/app/components/concerns/header.rb b/app/components/concerns/header.rb index 9b1b21937..aa9700c0d 100644 --- a/app/components/concerns/header.rb +++ b/app/components/concerns/header.rb @@ -17,7 +17,7 @@ module Header end tag.header do - safe_join([before, content_tag(heading_tag, title), (capture(&block) if block_given?)].compact) + safe_join([before, content_tag(heading_tag, title), (capture(&block) if block)].compact) end end