From daa35845dadffcdee73b597b5b6f1ebbe087a49d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 4 Sep 2023 18:22:58 +0200 Subject: [PATCH] Add and apply Style/RedundantStringEscape rule This rule was added in rubocop 1.37.0. It's particularly useful in the background image spec, since now there's one less backslash to decipher when reading the code :). --- .rubocop.yml | 3 +++ spec/components/budgets/budget_component_spec.rb | 2 +- spec/system/proposals_spec.rb | 4 ++-- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 6fbc9c70d..0db5b5e83 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -691,6 +691,9 @@ Style/RedundantReturn: Style/RedundantSelf: Enabled: true +Style/RedundantStringEscape: + Enabled: true + Style/SafeNavigation: Enabled: true diff --git a/spec/components/budgets/budget_component_spec.rb b/spec/components/budgets/budget_component_spec.rb index 7567b03e5..3c624f39e 100644 --- a/spec/components/budgets/budget_component_spec.rb +++ b/spec/components/budgets/budget_component_spec.rb @@ -73,7 +73,7 @@ describe Budgets::BudgetComponent do expect(page).to have_css ".budget-header.with-background-image" expect(page).to have_css ".budget-header[style*='background-image:']" \ - "[style*='url(\\''][style*='clippy_with_\\\\\'quotes\\\\\'.jpg']" + "[style*='url(\\''][style*='clippy_with_\\\\'quotes\\\\'.jpg']" end end end diff --git a/spec/system/proposals_spec.rb b/spec/system/proposals_spec.rb index 6bd950fef..8c1636a57 100644 --- a/spec/system/proposals_spec.rb +++ b/spec/system/proposals_spec.rb @@ -325,8 +325,8 @@ describe "Proposals" do proposal = create(:proposal) visit proposal_path(proposal) - expect(page).to have_css "meta[name='twitter:title'][content=\'#{proposal.title}\']", visible: :hidden - expect(page).to have_css "meta[property='og:title'][content=\'#{proposal.title}\']", visible: :hidden + expect(page).to have_css "meta[name='twitter:title'][content='#{proposal.title}']", visible: :hidden + expect(page).to have_css "meta[property='og:title'][content='#{proposal.title}']", visible: :hidden end scenario "Create and publish", :with_frozen_time do