Merge pull request #3085 from consul/backport-1196-fix_flaky_legislation_random_order_spec

Fix flaky spec: Legislation Proposals Each user has a different and consistent random proposals order

app/controllers/legislation/processes_controller.rb

@@ -117,13 +117,12 @@ class Legislation::ProcessesController < Legislation::BaseController
     end
 
     def set_random_seed
-      seed = begin
-               Float(params[:random_seed] || session[:random_seed] || (rand(99) / 100.0))
-             rescue
-               0
-             end
-      session[:random_seed], params[:random_seed] = seed
+      seed = (params[:random_seed] || session[:random_seed] || rand).to_f
       seed = (-1..1).cover?(seed) ? seed : 1
+
+      session[:random_seed] = seed
+      params[:random_seed] = seed
+
       ::Legislation::Proposal.connection.execute "select setseed(#{seed})"
     end
 end