From d7b8777395b1a8dd04c6b32931c1eb71e7b7cdd8 Mon Sep 17 00:00:00 2001
From: Bertocq <bertocq@gmail.com>
Date: Mon, 26 Jun 2017 18:03:40 +0200
Subject: [PATCH] Fix all Layout/SpaceAroundEqualsInParameterDefault rubocop
 issues from rubocop_todo list

---
 .rubocop_todo.yml                        | 22 ----------------------
 app/helpers/cache_keys_helper.rb         |  4 ++--
 app/helpers/proposals_helper.rb          |  2 +-
 app/helpers/spending_proposals_helper.rb |  2 +-
 app/helpers/stats_helper.rb              |  8 ++++----
 app/helpers/tracks_helper.rb             |  2 +-
 app/helpers/valuation_helper.rb          |  2 +-
 app/mailers/devise_mailer.rb             |  2 +-
 app/models/comment.rb                    |  2 +-
 app/models/officing/residence.rb         |  2 +-
 app/models/tag_cloud.rb                  |  2 +-
 app/models/verification/residence.rb     |  2 +-
 lib/acts_as_paranoid_aliases.rb          |  2 +-
 lib/manager_authenticator.rb             |  2 +-
 spec/support/common_actions.rb           |  4 ++--
 15 files changed, 19 insertions(+), 41 deletions(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 6e17b627b..bfc783e4e 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -557,28 +557,6 @@ Style/RescueModifier:
     - 'app/controllers/concerns/commentable_actions.rb'
     - 'app/controllers/verification/sms_controller.rb'
 
-# Offense count: 20
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: space, no_space
-Layout/SpaceAroundEqualsInParameterDefault:
-  Exclude:
-    - 'app/helpers/cache_keys_helper.rb'
-    - 'app/helpers/proposals_helper.rb'
-    - 'app/helpers/spending_proposals_helper.rb'
-    - 'app/helpers/stats_helper.rb'
-    - 'app/helpers/tracks_helper.rb'
-    - 'app/helpers/valuation_helper.rb'
-    - 'app/mailers/devise_mailer.rb'
-    - 'app/models/comment.rb'
-    - 'app/models/tag_cloud.rb'
-    - 'app/models/verification/residence.rb'
-    - 'lib/acts_as_paranoid_aliases.rb'
-    - 'lib/capistrano/template.rb'
-    - 'lib/census_api.rb'
-    - 'lib/manager_authenticator.rb'
-    - 'spec/support/common_actions.rb'
-
 # Offense count: 66
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment.
diff --git a/app/helpers/cache_keys_helper.rb b/app/helpers/cache_keys_helper.rb
index 566b3cd81..75fc4a0ea 100644
--- a/app/helpers/cache_keys_helper.rb
+++ b/app/helpers/cache_keys_helper.rb
@@ -1,11 +1,11 @@
 module CacheKeysHelper
 
-  def locale_and_user_status(authorable=nil)
+  def locale_and_user_status(authorable = nil)
     @cache_key_user ||= calculate_user_status(authorable)
     "#{I18n.locale}/#{@cache_key_user}"
   end
 
-  def calculate_user_status(authorable=nil)
+  def calculate_user_status(authorable = nil)
     user_status = "user"
 
     if user_signed_in?
diff --git a/app/helpers/proposals_helper.rb b/app/helpers/proposals_helper.rb
index 578cd1d8e..37425d573 100644
--- a/app/helpers/proposals_helper.rb
+++ b/app/helpers/proposals_helper.rb
@@ -18,7 +18,7 @@ module ProposalsHelper
     end
   end
 
-  def namespaced_proposal_path(proposal, options={})
+  def namespaced_proposal_path(proposal, options = {})
     @namespace_proposal_path ||= namespace
     case @namespace_proposal_path
     when "management"
diff --git a/app/helpers/spending_proposals_helper.rb b/app/helpers/spending_proposals_helper.rb
index 26026952f..81d16e5fd 100644
--- a/app/helpers/spending_proposals_helper.rb
+++ b/app/helpers/spending_proposals_helper.rb
@@ -4,7 +4,7 @@ module SpendingProposalsHelper
     ActsAsTaggableOn::Tag.spending_proposal_tags.pluck(:name)
   end
 
-  def namespaced_spending_proposal_path(spending_proposal, options={})
+  def namespaced_spending_proposal_path(spending_proposal, options = {})
     @namespace_spending_proposal_path ||= namespace
     case @namespace_spending_proposal_path
     when "management"
diff --git a/app/helpers/stats_helper.rb b/app/helpers/stats_helper.rb
index d8eff0ac2..19b54a5a2 100644
--- a/app/helpers/stats_helper.rb
+++ b/app/helpers/stats_helper.rb
@@ -1,27 +1,27 @@
 module StatsHelper
 
-  def events_chart_tag(events, opt={})
+  def events_chart_tag(events, opt = {})
     events = events.join(',') if events.is_a? Array
     opt[:data] ||= {}
     opt[:data][:graph] = admin_api_stats_path(events: events)
     content_tag :div, "", opt
   end
 
-  def visits_chart_tag(opt={})
+  def visits_chart_tag(opt = {})
     events = events.join(',') if events.is_a? Array
     opt[:data] ||= {}
     opt[:data][:graph] = admin_api_stats_path(visits: true)
     content_tag :div, "", opt
   end
 
-  def spending_proposals_chart_tag(opt={})
+  def spending_proposals_chart_tag(opt = {})
     events = events.join(',') if events.is_a? Array
     opt[:data] ||= {}
     opt[:data][:graph] = admin_api_stats_path(spending_proposals: true)
     content_tag :div, "", opt
   end
 
-  def budget_investments_chart_tag(opt={})
+  def budget_investments_chart_tag(opt = {})
     events = events.join(',') if events.is_a? Array
     opt[:data] ||= {}
     opt[:data][:graph] = admin_api_stats_path(budget_investments: true)
diff --git a/app/helpers/tracks_helper.rb b/app/helpers/tracks_helper.rb
index 557d71802..0d6793e08 100644
--- a/app/helpers/tracks_helper.rb
+++ b/app/helpers/tracks_helper.rb
@@ -1,6 +1,6 @@
 module TracksHelper
 
-  def track_event(data={})
+  def track_event(data = {})
     track_data = ""
     prefix = " data-track-event-"
     data.each do |key, value|
diff --git a/app/helpers/valuation_helper.rb b/app/helpers/valuation_helper.rb
index ded5fa0ed..4913b3d00 100644
--- a/app/helpers/valuation_helper.rb
+++ b/app/helpers/valuation_helper.rb
@@ -1,6 +1,6 @@
 module ValuationHelper
 
-  def valuator_select_options(valuator=nil)
+  def valuator_select_options(valuator = nil)
     if valuator.present?
       Valuator.where.not(id: valuator.id).order("description ASC").order("users.email ASC").includes(:user).collect { |v| [ v.description_or_email, v.id ] }.prepend([valuator.description_or_email, valuator.id])
     else
diff --git a/app/mailers/devise_mailer.rb b/app/mailers/devise_mailer.rb
index 6c053cb52..a914477fe 100644
--- a/app/mailers/devise_mailer.rb
+++ b/app/mailers/devise_mailer.rb
@@ -5,7 +5,7 @@ class DeviseMailer < Devise::Mailer
 
   protected
 
-  def devise_mail(record, action, opts={})
+  def devise_mail(record, action, opts = {})
     I18n.with_locale record.locale do
       super(record, action, opts)
     end
diff --git a/app/models/comment.rb b/app/models/comment.rb
index 522b7324b..fa9db729f 100644
--- a/app/models/comment.rb
+++ b/app/models/comment.rb
@@ -44,7 +44,7 @@ class Comment < ActiveRecord::Base
 
   after_create :call_after_commented
 
-  def self.build(commentable, user, body, p_id=nil)
+  def self.build(commentable, user, body, p_id = nil)
     new commentable: commentable,
         user_id:     user.id,
         body:        body,
diff --git a/app/models/officing/residence.rb b/app/models/officing/residence.rb
index 1714bbf0e..63250d041 100644
--- a/app/models/officing/residence.rb
+++ b/app/models/officing/residence.rb
@@ -13,7 +13,7 @@ class Officing::Residence
   validate :allowed_age
   validate :residence_in_madrid
 
-  def initialize(attrs={})
+  def initialize(attrs = {})
     super
     clean_document_number
   end
diff --git a/app/models/tag_cloud.rb b/app/models/tag_cloud.rb
index 107ecbf1a..b0882af82 100644
--- a/app/models/tag_cloud.rb
+++ b/app/models/tag_cloud.rb
@@ -2,7 +2,7 @@ class TagCloud
 
   attr_accessor :resource_model, :scope
 
-  def initialize(resource_model, scope=nil)
+  def initialize(resource_model, scope = nil)
     @resource_model = resource_model
     @scope = scope
   end
diff --git a/app/models/verification/residence.rb b/app/models/verification/residence.rb
index e1b2f6363..00f729d2c 100644
--- a/app/models/verification/residence.rb
+++ b/app/models/verification/residence.rb
@@ -17,7 +17,7 @@ class Verification::Residence
   validate :allowed_age
   validate :document_number_uniqueness
 
-  def initialize(attrs={})
+  def initialize(attrs = {})
     self.date_of_birth = parse_date('date_of_birth', attrs)
     attrs = remove_date('date_of_birth', attrs)
     super
diff --git a/lib/acts_as_paranoid_aliases.rb b/lib/acts_as_paranoid_aliases.rb
index cf0c0bac8..17587fca8 100644
--- a/lib/acts_as_paranoid_aliases.rb
+++ b/lib/acts_as_paranoid_aliases.rb
@@ -25,7 +25,7 @@ module ActsAsParanoidAliases
         update_attribute(:confirmed_hide_at, Time.current)
       end
 
-      def restore(opts={})
+      def restore(opts = {})
         return false unless hidden?
         super(opts)
         update_attribute(:confirmed_hide_at, nil)
diff --git a/lib/manager_authenticator.rb b/lib/manager_authenticator.rb
index bd61d97a5..8f8d453f7 100644
--- a/lib/manager_authenticator.rb
+++ b/lib/manager_authenticator.rb
@@ -1,6 +1,6 @@
 class ManagerAuthenticator
 
-  def initialize(data={})
+  def initialize(data = {})
     @manager = {login: data[:login], user_key: data[:clave_usuario], date: data[:fecha_conexion]}.with_indifferent_access
   end
 
diff --git a/spec/support/common_actions.rb b/spec/support/common_actions.rb
index 327943931..209ddf800 100644
--- a/spec/support/common_actions.rb
+++ b/spec/support/common_actions.rb
@@ -1,6 +1,6 @@
 module CommonActions
 
-  def sign_up(email='manuela@consul.dev', password='judgementday')
+  def sign_up(email = 'manuela@consul.dev', password = 'judgementday')
     visit '/'
 
     click_link 'Register'
@@ -109,7 +109,7 @@ module CommonActions
     SCRIPT
   end
 
-  def error_message(resource_model=nil)
+  def error_message(resource_model = nil)
     resource_model ||= "(.*)"
     /\d errors? prevented this #{resource_model} from being saved:/
   end