Split test in budget valuation component

We're going to add more cases and the test for the link to the evaluate
would become too big, so we're splitting it.

spec/components/valuation/budgets/row_component_spec.rb

@@ -5,46 +5,72 @@ describe Valuation::Budgets::RowComponent do
 
   before { sign_in(valuator.user) }
 
-  it "Displays visible and assigned investments count when budget is in valuating phase" do
+  describe "investments count" do
-    budget = create(:budget, :valuating, name: "Sports")
+    it "counts visible and assigned investments when the budget is in the valuating phase" do
-    create(:budget_investment, :visible_to_valuators, budget: budget, valuators: [valuator])
+      budget = create(:budget, :valuating)
-    create(:budget_investment, :invisible_to_valuators, budget: budget, valuators: [valuator])
+      create(:budget_investment, :visible_to_valuators, budget: budget, valuators: [valuator])
-    create(:budget_investment, :visible_to_valuators, budget: budget)
+      create(:budget_investment, :invisible_to_valuators, budget: budget, valuators: [valuator])
+      create(:budget_investment, :visible_to_valuators, budget: budget)
 
-    render_inline Valuation::Budgets::RowComponent.new(budget: budget)
+      render_inline Valuation::Budgets::RowComponent.new(budget: budget)
 
-    expect(page).to have_selector(".investments-count", text: "1")
+      expect(page).to have_selector ".investments-count", text: "1"
+    end
+
+    it "displays zero when the budget is not in the valuating phase" do
+      budget = create(:budget, %i[accepting finished].sample)
+      create(:budget_investment, :visible_to_valuators, budget: budget, valuators: [valuator])
+
+      render_inline Valuation::Budgets::RowComponent.new(budget: budget)
+
+      expect(page).to have_selector ".investments-count", text: "0"
+    end
   end
 
-  it "Displays zero as investments count when budget is not in valuating phase" do
+  describe "link to evaluate investments" do
-    budget = create(:budget, %i[accepting finished].sample, name: "Sports")
+    it "is shown when the valuator has visible investments assigned in the valuating phase" do
-    create(:budget_investment, :visible_to_valuators, budget: budget, valuators: [valuator])
+      budget = create(:budget, :valuating)
+      create(:budget_investment, :visible_to_valuators, budget: budget, valuators: [valuator])
 
-    render_inline Valuation::Budgets::RowComponent.new(budget: budget)
+      render_inline Valuation::Budgets::RowComponent.new(budget: budget)
 
-    expect(page).to have_selector(".investments-count", text: "0")
+      expect(page).to have_link "Evaluate"
-  end
+    end
 
-  it "Displays the link to evaluate investments when valuator has visible investments assigned and budget is
+    it "is not shown when the assigned investments aren't visible to valuators" do
-      in valuating phase" do
+      budget = create(:budget, :valuating)
-    valuating = create(:budget, :valuating)
+      create(:budget_investment, :invisible_to_valuators, budget: budget, valuators: [valuator])
-    create(:budget_investment, :visible_to_valuators, budget: valuating, valuators: [valuator])
-    valuating_invisible = create(:budget, :valuating)
-    create(:budget_investment, :invisible_to_valuators, budget: valuating_invisible, valuators: [valuator])
-    valuating_unassigned = create(:budget, :valuating)
-    create(:budget_investment, :visible_to_valuators, budget: valuating_unassigned)
-    accepting = create(:budget, :accepting)
-    create(:budget_investment, :visible_to_valuators, budget: accepting, valuators: [valuator])
-    finished = create(:budget, :finished)
-    create(:budget_investment, :visible_to_valuators, budget: finished, valuators: [valuator])
-    budgets = [valuating, valuating_invisible, valuating_unassigned, accepting, finished]
 
-    render_inline Valuation::Budgets::RowComponent.with_collection(budgets)
+      render_inline Valuation::Budgets::RowComponent.new(budget: budget)
 
-    expect(page.find("#budget_#{valuating.id}")).to have_link("Evaluate")
+      expect(page).not_to have_link "Evaluate"
-    expect(page.find("#budget_#{valuating_invisible.id}")).not_to have_link("Evaluate")
+    end
-    expect(page.find("#budget_#{valuating_unassigned.id}")).not_to have_link("Evaluate")
+
-    expect(page.find("#budget_#{accepting.id}")).not_to have_link("Evaluate")
+    it "is not shown when the valuator doesn't have assigned investments" do
-    expect(page.find("#budget_#{finished.id}")).not_to have_link("Evaluate")
+      budget = create(:budget, :valuating)
+      create(:budget_investment, :visible_to_valuators, budget: budget)
+
+      render_inline Valuation::Budgets::RowComponent.new(budget: budget)
+
+      expect(page).not_to have_link "Evaluate"
+    end
+
+    it "is not shown when the budget hasn't reached the valuating phase" do
+      budget = create(:budget, :accepting)
+      create(:budget_investment, :visible_to_valuators, budget: budget, valuators: [valuator])
+
+      render_inline Valuation::Budgets::RowComponent.new(budget: budget)
+
+      expect(page).not_to have_link "Evaluate"
+    end
+
+    it "is not shown when the valuating phase is over" do
+      budget = create(:budget, :finished)
+      create(:budget_investment, :visible_to_valuators, budget: budget, valuators: [valuator])
+
+      render_inline Valuation::Budgets::RowComponent.new(budget: budget)
+
+      expect(page).not_to have_link "Evaluate"
+    end
   end
 end