Simplify main layout styles

We were using a "push" div in order to force the footer to the bottom,
and were using a wrapper with a minimum height and negative margins.

The same thing can be accomplished using flex and making the wrapper
fill the empty space, which in my humble opinion simplifies the code and
makes it easier to follow.

We could further simplify the code by removing the wrapper div or the
footer wrapper, although I'm not sure the benefits overcome potential
inconveniences caused to other institutions who might have custom styles
based on the existence of these wrappers.
This commit is contained in:
Javi Martín
2020-11-07 12:40:34 +01:00
parent 682f374598
commit d4a360c7fb
4 changed files with 10 additions and 21 deletions

View File

@@ -44,8 +44,6 @@
<%= render "layouts/flash" %>
<%= yield %>
<div class="push"></div>
</div>
<div class="footer">
<%= render "layouts/footer" %>