Refactor nested documentable spec

This commit is contained in:
Senén Rodero Rodríguez
2017-08-23 21:16:06 +02:00
parent 0db49fda4e
commit d34216b5a7

View File

@@ -19,236 +19,228 @@ shared_examples "nested documentable" do |documentable_factory_name, path, docum
end end
context "Nested documents" do scenario "Should show new document link when max documents allowed limit is not reached" do
login_as user
visit send(path, arguments)
context "On documentable new page" do expect(page).to have_selector "#new_document_link", visible: true
end
scenario "Should show new document link" do scenario "Should not show new document link when documentable max documents allowed limit is reached", :js do
login_as user login_as user
visit send(path, arguments) visit send(path, arguments)
expect(page).to have_selector "#new_document_link", visible: true click_link "Add new document"
end sleep 1
click_link "Add new document"
sleep 1
click_link "Add new document"
scenario "Should not show new document when documentable max documents allowed limit is reached", :js do expect(page).to have_selector "#new_document_link", visible: false
login_as user end
visit send(path, arguments)
click_link "Add new document" scenario "Should not show max documents warning when no documents added", :js do
sleep 1 login_as user
click_link "Add new document" visit send(path, arguments)
sleep 1
click_link "Add new document"
expect(page).to have_selector "#new_document_link", visible: false expect(page).to have_selector ".max-documents-notice", visible: false
end end
scenario "Should not show max documents warning when no documents added", :js do scenario "Should show max documents warning when max documents allowed limit is reached", :js do
login_as user login_as user
visit send(path, arguments) visit send(path, arguments)
expect(page).to have_selector ".max-documents-notice", visible: false click_link "Add new document"
end sleep 1
click_link "Add new document"
sleep 1
click_link "Add new document"
scenario "Should show max documents warning when max documents allowed limit is reached", :js do expect(page).to have_selector ".max-documents-notice", visible: true
login_as user end
visit send(path, arguments)
click_link "Add new document" scenario "Should hide max documents warning after any document removal", :js do
sleep 1 login_as user
click_link "Add new document" visit send(path, arguments)
sleep 1
click_link "Add new document"
expect(page).to have_selector ".max-documents-notice", visible: true click_link "Add new document"
end sleep 1
click_link "Add new document"
sleep 1
click_link "Add new document"
sleep 1
within "#document_0" do
find("a", text: "Remove document").click
end
sleep 1
scenario "Should hide max documents warning after any document link", :js do expect(page).to have_selector ".max-documents-notice", visible: false
login_as user end
visit send(path, arguments)
click_link "Add new document" scenario "Should update nested document file name after choosing a file", :js do
sleep 1 login_as user
click_link "Add new document" visit send(path, arguments)
sleep 1
click_link "Add new document"
sleep 1
within "#document_0" do
find("a", text: "Remove document").click
end
sleep 1
expect(page).to have_selector ".max-documents-notice", visible: false click_link "Add new document"
end attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf"
scenario "Should update nested document file name after choosing a file", :js do expect(page).to have_selector ".file-name", text: "empty.pdf"
login_as user end
visit send(path, arguments)
click_link "Add new document" scenario "Should update nested document file title with file name after choosing a file when no title defined", :js do
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf" login_as user
visit send(path, arguments)
expect(page).to have_selector ".file-name", text: "empty.pdf" click_link "Add new document"
end attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf"
sleep 1
scenario "Should update nested document file title with file name after choosing a file when no title defined", :js do expect(find("##{documentable_factory_name}_documents_attributes_0_title").value).to eq "empty.pdf"
login_as user end
visit send(path, arguments)
click_link "Add new document" scenario "Should not update nested document file title with file name after choosing a file when title already defined", :js do
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf" login_as user
sleep 1 visit send(path, arguments)
expect(find("##{documentable_factory_name}_documents_attributes_0_title").value).to eq "empty.pdf" click_link "Add new document"
end fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title"
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf"
sleep 1
scenario "Should not update nested document file title with file name after choosing a file when title already defined", :js do expect(find("##{documentable_factory_name}_documents_attributes_0_title").value).to eq "Title"
login_as user end
visit send(path, arguments)
click_link "Add new document" scenario "Should update loading bar style after valid file upload", :js do
fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title" login_as user
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf" visit send(path, arguments)
sleep 1
expect(find("##{documentable_factory_name}_documents_attributes_0_title").value).to eq "Title" click_link "Add new document"
end fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title"
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf"
sleep 1
scenario "Should update loading bar style after valid file upload", :js do expect(page).to have_selector ".loading-bar.complete"
login_as user end
visit send(path, arguments)
click_link "Add new document" scenario "Should update loading bar style after unvalid file upload", :js do
fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title" login_as user
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf" visit send(path, arguments)
sleep 1
expect(page).to have_selector ".loading-bar.complete" click_link "Add new document"
end fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title"
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/logo_header.png"
sleep 1
scenario "Should update loading bar style after unvalid file upload", :js do expect(page).to have_selector ".loading-bar.errors"
login_as user end
visit send(path, arguments)
click_link "Add new document" scenario "Should update document cached_attachment field after valid file upload", :js do
fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title" login_as user
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/logo_header.png" visit send(path, arguments)
sleep 1
expect(page).to have_selector ".loading-bar.errors" click_link "Add new document"
end fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title"
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf"
sleep 1
scenario "Should update document cached_attachment field after valid file upload", :js do expect(find("input[name='#{documentable_factory_name}[documents_attributes][0][cached_attachment]']", visible: false).value).to include("empty.pdf")
login_as user end
visit send(path, arguments)
click_link "Add new document" scenario "Should not update document cached_attachment field after unvalid file upload", :js do
fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title" login_as user
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf" visit send(path, arguments)
sleep 1
expect(find("input[name='#{documentable_factory_name}[documents_attributes][0][cached_attachment]']", visible: false).value).to include("empty.pdf") click_link "Add new document"
end fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title"
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/logo_header.png"
sleep 1
scenario "Should not update document cached_attachment field after unvalid file upload", :js do expect(find("input[name='#{documentable_factory_name}[documents_attributes][0][cached_attachment]']", visible: false).value).to eq ""
login_as user end
visit send(path, arguments)
click_link "Add new document" scenario "Should show document errors after unvalid file upload", :js do
fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title" login_as user
attach_file "#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/logo_header.png" visit send(path, arguments)
sleep 1
expect(find("input[name='#{documentable_factory_name}[documents_attributes][0][cached_attachment]']", visible: false).value).to eq "" click_link "Add new document"
end sleep 1
click_on submit_button
scenario "Should show document errors after unvalid file upload", :js do within "#document_0" do
login_as user expect(page).to have_content("can't be blank", count: 2)
visit send(path, arguments) end
end
click_link "Add new document" scenario "Should delete document after valid file upload and click on remove button", :js do
sleep 1 login_as user
click_on submit_button visit send(path, arguments)
within "#document_0" do
expect(page).to have_content("can't be blank", count: 2)
end
end
scenario "Should delete document after valid file upload and click on remove button", :js do
login_as user
visit send(path, arguments)
attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
within "#document_0" do
click_link "Remove document"
end
expect(page).not_to have_selector("#document_0")
end
scenario "Should delete document after valid file upload and click on remove button", :js do
login_as user
visit send(path, arguments)
attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
within "#document_0" do
click_link "Remove document"
end
expect(page).to have_content "Document was deleted successfully."
end
scenario "Should show successful notice when resource filled correctly without any nested documents", :js do
login_as user
visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name
click_on submit_button
expect(page).to have_content documentable_success_notice
end
scenario "Should show successful notice when resource filled correctly and after valid file uploads", :js do
login_as user
visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name
attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
click_on submit_button
expect(page).to have_content documentable_success_notice
end
scenario "Should show new resource with new document after successful creation with one uploaded file", :js do
login_as user
visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name
attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
click_on submit_button
redirected_to_resource_show_or_navigate_to
expect(page).to have_content "Documents (1)"
end
scenario "Should show created resource with new document after successful creation with maximum allowed uploaded files", :js do
login_as user
visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name
documentable.class.max_documents_allowed.times.each do |index|
attach_new_file(documentable_factory_name, index , "spec/fixtures/files/empty.pdf")
end
click_on submit_button
redirected_to_resource_show_or_navigate_to
expect(page).to have_content "Documents (#{documentable.class.max_documents_allowed})"
end
attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
within "#document_0" do
click_link "Remove document"
end end
expect(page).not_to have_selector("#document_0")
end
scenario "Should delete document after valid file upload and click on remove button", :js do
login_as user
visit send(path, arguments)
attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
within "#document_0" do
click_link "Remove document"
end
expect(page).to have_content "Document was deleted successfully."
end
scenario "Should show successful notice when resource filled correctly without any nested documents", :js do
login_as user
visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name
click_on submit_button
expect(page).to have_content documentable_success_notice
end
scenario "Should show successful notice when resource filled correctly and after valid file uploads", :js do
login_as user
visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name
attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
click_on submit_button
expect(page).to have_content documentable_success_notice
end
scenario "Should show new document after successful creation with one uploaded file", :js do
login_as user
visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name
attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
click_on submit_button
redirected_to_resource_show_or_navigate_to
expect(page).to have_content "Documents (1)"
end
scenario "Should show resource with new document after successful creation with maximum allowed uploaded files", :js do
login_as user
visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name
documentable.class.max_documents_allowed.times.each do |index|
attach_new_file(documentable_factory_name, index , "spec/fixtures/files/empty.pdf")
end
click_on submit_button
redirected_to_resource_show_or_navigate_to
expect(page).to have_content "Documents (#{documentable.class.max_documents_allowed})"
end end
end end