From d1f1e1dfeadb739f3706b4c7693972b19cf11cf0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Mon, 29 May 2023 17:45:11 +0200
Subject: [PATCH] Add notices when creating and updating geozones

Just like we do in pretty much every section in the admin area.
---
 app/controllers/admin/geozones_controller.rb | 4 ++--
 config/locales/en/admin.yml                  | 4 ++++
 config/locales/es/admin.yml                  | 4 ++++
 spec/system/admin/geozones_spec.rb           | 5 +++++
 4 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/app/controllers/admin/geozones_controller.rb b/app/controllers/admin/geozones_controller.rb
index 930d2877d..be2f01ecb 100644
--- a/app/controllers/admin/geozones_controller.rb
+++ b/app/controllers/admin/geozones_controller.rb
@@ -17,7 +17,7 @@ class Admin::GeozonesController < Admin::BaseController
     @geozone = Geozone.new(geozone_params)
 
     if @geozone.save
-      redirect_to admin_geozones_path
+      redirect_to admin_geozones_path, notice: t("admin.geozones.create.notice")
     else
       render :new
     end
@@ -25,7 +25,7 @@ class Admin::GeozonesController < Admin::BaseController
 
   def update
     if @geozone.update(geozone_params)
-      redirect_to admin_geozones_path
+      redirect_to admin_geozones_path, notice: t("admin.geozones.update.notice")
     else
       render :edit
     end
diff --git a/config/locales/en/admin.yml b/config/locales/en/admin.yml
index 50ca7c430..e40fba1c8 100644
--- a/config/locales/en/admin.yml
+++ b/config/locales/en/admin.yml
@@ -1393,6 +1393,8 @@ en:
         code_help: Response code for this geozone on the census API
         coordinates: Coordinates
         coordinates_help: Coordinates that will generate a clickable area on an HTML image map
+      create:
+        notice: "Geozone created successfully"
       edit:
         form:
           submit_button: Save changes
@@ -1404,6 +1406,8 @@ en:
       delete:
         success: Geozone successfully deleted
         error: This geozone can't be deleted since there are elements attached to it
+      update:
+        notice: "Geozone updated successfully"
     signature_sheets:
       author: Author
       created_at: Creation date
diff --git a/config/locales/es/admin.yml b/config/locales/es/admin.yml
index 2bcf7799f..8234b6cc8 100644
--- a/config/locales/es/admin.yml
+++ b/config/locales/es/admin.yml
@@ -1393,6 +1393,8 @@ es:
         code_help: Código de respuesta para esta zona en la API del censo
         coordinates: Coordenadas
         coordinates_help: Coordenadas que generarán una zona clicable en un mapa de imagen HTML
+      create:
+        notice: "Zona creada correctamente"
       edit:
         form:
           submit_button: Guardar cambios
@@ -1404,6 +1406,8 @@ es:
       delete:
         success: Zona borrada correctamente
         error: No se puede borrar la zona porque ya tiene elementos asociados
+      update:
+        notice: "Zona actualizada correctamente"
     signature_sheets:
       author: Autor
       created_at: Fecha de creación
diff --git a/spec/system/admin/geozones_spec.rb b/spec/system/admin/geozones_spec.rb
index 2617606bd..392f8f8aa 100644
--- a/spec/system/admin/geozones_spec.rb
+++ b/spec/system/admin/geozones_spec.rb
@@ -27,6 +27,7 @@ describe "Admin geozones", :admin do
 
     click_button "Save changes"
 
+    expect(page).to have_content "Geozone created successfully"
     expect(page).to have_content "Fancy District"
 
     visit admin_geozones_path
@@ -46,6 +47,8 @@ describe "Admin geozones", :admin do
 
     click_button "Save changes"
 
+    expect(page).to have_content "Geozone updated successfully"
+
     within("#geozone_#{geozone.id}") do
       expect(page).to have_content "New geozone name"
       expect(page).to have_content "333"
@@ -64,6 +67,8 @@ describe "Admin geozones", :admin do
 
     click_button "Save changes"
 
+    expect(page).to have_content "Geozone updated successfully"
+
     within("#geozone_#{geozone.id}") do
       expect(page).to have_content "New geozone name"
     end