From d0cb26c08607e8d8bb18cc2d06faf926dbef19ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Sun, 8 Nov 2020 14:02:04 +0100
Subject: [PATCH] Use CSS to style footer links

This way additional elements added through the "footer" content block
will also have the same styles.
---
 app/assets/stylesheets/layout.scss |  4 ++++
 app/views/layouts/_footer.html.erb | 10 +++++-----
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss
index d5bcd17f4..85dbcf364 100644
--- a/app/assets/stylesheets/layout.scss
+++ b/app/assets/stylesheets/layout.scss
@@ -1758,6 +1758,10 @@ table {
 
 .social {
 
+  li {
+    display: inline-block;
+  }
+
   a {
     font-size: rem-calc(24);
     margin: 0 $line-height / 2;
diff --git a/app/views/layouts/_footer.html.erb b/app/views/layouts/_footer.html.erb
index a627e3228..8b2d41f59 100644
--- a/app/views/layouts/_footer.html.erb
+++ b/app/views/layouts/_footer.html.erb
@@ -35,7 +35,7 @@
       <div class="text-right">
         <ul>
           <% if setting["twitter_handle"] %>
-            <li class="inline-block">
+            <li>
               <%= link_to "https://twitter.com/#{setting["twitter_handle"]}", target: "_blank",
                            title: t("shared.go_to_page") + t("social.twitter", org: setting["org_name"]) + t("shared.target_blank") do %>
                               <span class="show-for-sr"><%= t("social.twitter", org: setting["org_name"]) %></span>
@@ -44,7 +44,7 @@
             </li>
           <% end %>
           <% if setting["facebook_handle"] %>
-            <li class="inline-block">
+            <li>
               <%= link_to "https://www.facebook.com/#{setting["facebook_handle"]}/", target: "_blank",
                           title: t("shared.go_to_page") + t("social.facebook", org: setting["org_name"]) + t("shared.target_blank") do %>
                           <span class="show-for-sr"><%= t("social.facebook", org: setting["org_name"]) %></span>
@@ -53,7 +53,7 @@
             </li>
           <% end %>
           <% if setting["youtube_handle"] %>
-            <li class="inline-block">
+            <li>
               <%= link_to "https://www.youtube.com/#{setting["youtube_handle"]}", target: "_blank",
                           title: t("shared.go_to_page") + t("social.youtube", org: setting["org_name"]) + t("shared.target_blank") do %>
                           <span class="show-for-sr"><%= t("social.youtube", org: setting["org_name"]) %></span>
@@ -62,7 +62,7 @@
             </li>
           <% end %>
           <% if setting["telegram_handle"] %>
-            <li class="inline-block">
+            <li>
               <%= link_to "https://www.telegram.me/#{setting["telegram_handle"]}", target: "_blank",
                           title: t("shared.go_to_page") + t("social.telegram", org: setting["org_name"]) + t("shared.target_blank") do %>
                           <span class="show-for-sr"><%= t("social.telegram", org: setting["org_name"]) %></span>
@@ -71,7 +71,7 @@
             </li>
           <% end %>
           <% if setting["instagram_handle"] %>
-            <li class="inline-block">
+            <li>
               <%= link_to "https://www.instagram.com/#{setting["instagram_handle"]}", target: "_blank",
                           title: t("shared.go_to_page") + t("social.instagram", org: setting["org_name"]) + t("shared.target_blank") do %>
                           <span class="show-for-sr"><%= t("social.instagram", org: setting["org_name"]) %></span>