From d077f7c14b378cf15498e0d0fda20cb5dee95a61 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 5 Nov 2019 16:54:30 +0100 Subject: [PATCH] Refactor method to display valuator abilities Using `select` is easier to follow than adding `nil` to an array and then using `compact`. --- app/helpers/valuators_helper.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/app/helpers/valuators_helper.rb b/app/helpers/valuators_helper.rb index d99f5f957..c32758077 100644 --- a/app/helpers/valuators_helper.rb +++ b/app/helpers/valuators_helper.rb @@ -4,8 +4,9 @@ module ValuatorsHelper end def valuator_abilities(valuator) - [valuator.can_comment ? I18n.t("admin.valuators.index.can_comment") : nil, - valuator.can_edit_dossier ? I18n.t("admin.valuators.index.can_edit_dossier") : nil - ].compact.join(", ") + %w[can_comment can_edit_dossier] + .select { |permission| valuator.send("#{permission}?") } + .map { |permission| I18n.t("admin.valuators.index.#{permission}") } + .join(", ") end end