From d041d0680948b0c13c9b2196c5ad621c06c55364 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Fri, 27 Aug 2021 02:44:22 +0200
Subject: [PATCH] Make officing specs detect bugs in the menu links

In commit baaec3a29 we started using the JavaScript driver in tests
dealing with the user menu, and made all tests pass.

However, we didn't update some officing tests that were also passing
when there was a bug in the code. That's because now that these tests
use a JavaScript driver, the link to "Polling officers" is never present
before pressing the "Menu" item. So tests checking the link isn't
present when loading the page always pass.
---
 spec/system/officing_spec.rb | 35 +++++++++++++++++++++++++++++------
 1 file changed, 29 insertions(+), 6 deletions(-)

diff --git a/spec/system/officing_spec.rb b/spec/system/officing_spec.rb
index f894c3b89..c66a9188e 100644
--- a/spec/system/officing_spec.rb
+++ b/spec/system/officing_spec.rb
@@ -8,7 +8,9 @@ describe "Poll Officing" do
     login_as(user)
     visit root_path
 
-    expect(page).not_to have_link("Polling officers")
+    expect(page).not_to have_content "Menu"
+    expect(page).not_to have_link "Polling officers"
+
     visit officing_root_path
 
     expect(page).not_to have_current_path(officing_root_path)
@@ -18,10 +20,14 @@ describe "Poll Officing" do
 
   scenario "Access as moderator is not authorized" do
     create(:moderator, user: user)
+
     login_as(user)
     visit root_path
+    click_link "Menu"
+
+    expect(page).to have_link "Moderation"
+    expect(page).not_to have_link "Polling officers"
 
-    expect(page).not_to have_link("Polling officers")
     visit officing_root_path
 
     expect(page).not_to have_current_path(officing_root_path)
@@ -31,10 +37,14 @@ describe "Poll Officing" do
 
   scenario "Access as manager is not authorized" do
     create(:manager, user: user)
+
     login_as(user)
     visit root_path
+    click_link "Menu"
+
+    expect(page).to have_link "Management"
+    expect(page).not_to have_link "Polling officers"
 
-    expect(page).not_to have_link("Polling officers")
     visit officing_root_path
 
     expect(page).not_to have_current_path(officing_root_path)
@@ -43,11 +53,15 @@ describe "Poll Officing" do
   end
 
   scenario "Access as SDG manager is not authorized" do
+    Setting["feature.sdg"] = true
     create(:sdg_manager, user: user)
+
     login_as(user)
     visit root_path
+    click_link "Menu"
 
-    expect(page).not_to have_link("Polling officers")
+    expect(page).to have_link "SDG content"
+    expect(page).not_to have_link "Polling officers"
 
     visit officing_root_path
 
@@ -58,10 +72,14 @@ describe "Poll Officing" do
 
   scenario "Access as a valuator is not authorized" do
     create(:valuator, user: user)
+
     login_as(user)
     visit root_path
+    click_link "Menu"
+
+    expect(page).to have_link "Valuation"
+    expect(page).not_to have_link "Polling officers"
 
-    expect(page).not_to have_link("Polling officers")
     visit officing_root_path
 
     expect(page).not_to have_current_path(officing_root_path)
@@ -72,10 +90,15 @@ describe "Poll Officing" do
   scenario "Access as an administrator is not authorized" do
     create(:administrator, user: user)
     create(:poll)
+
     login_as(user)
     visit root_path
 
-    expect(page).not_to have_link("Polling officers")
+    click_link "Menu"
+
+    expect(page).to have_link "Administration"
+    expect(page).not_to have_link "Polling officers"
+
     visit officing_root_path
 
     expect(page).not_to have_current_path(officing_root_path)