consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename proposal_improvement_url to proposal_improvement_path to truly describe the value that the variable holds

Browse Source
This commit is contained in:
Bertocq
2017-05-31 12:51:01 +02:00
parent 469d4a02a9
commit cf8bc486e4
6 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/proposals_controller.rb
View File

@@ -56,8 +56,8 @@ class ProposalsController < ApplicationController
end end
def share def share
if Setting['proposal_improvement_url'].present? if Setting['proposal_improvement_path'].present?
@proposal_improvement_url = root_url + Setting['proposal_improvement_url'] @proposal_improvement_url = root_url + Setting['proposal_improvement_path']
end end
end end

2
config/locales/settings.en.yml
View File

@@ -44,4 +44,4 @@ en:
meta_keywords: "Keywords (SEO)" meta_keywords: "Keywords (SEO)"
verification_offices_url: Verification offices URL verification_offices_url: Verification offices URL
min_age_to_participate: Minimum age needed to participate min_age_to_participate: Minimum age needed to participate
proposal_improvement_url: Proposal improvement info internal link proposal_improvement_path: Proposal improvement info internal link

2
config/locales/settings.es.yml
View File

@@ -44,4 +44,4 @@ es:
meta_keywords: "Palabras clave (SEO)" meta_keywords: "Palabras clave (SEO)"
verification_offices_url: URL oficinas verificación verification_offices_url: URL oficinas verificación
min_age_to_participate: Edad mínima para participar min_age_to_participate: Edad mínima para participar
proposal_improvement_url: Link a información para mejorar propuestas proposal_improvement_path: Link a información para mejorar propuestas

2
db/dev_seeds.rb
View File

@@ -44,7 +44,7 @@ Setting.create(key: 'meta_description', value: 'Citizen Participation and Open G
Setting.create(key: 'meta_keywords', value: 'citizen participation, open government') Setting.create(key: 'meta_keywords', value: 'citizen participation, open government')
Setting.create(key: 'verification_offices_url', value: 'http://oficinas-atencion-ciudadano.url/') Setting.create(key: 'verification_offices_url', value: 'http://oficinas-atencion-ciudadano.url/')
Setting.create(key: 'min_age_to_participate', value: '16') Setting.create(key: 'min_age_to_participate', value: '16')
Setting.create(key: 'proposal_improvement_url', value: nil) Setting.create(key: 'proposal_improvement_path', value: nil)
puts " ✅" puts " ✅"
print "Creating Geozones" print "Creating Geozones"

2
db/seeds.rb
View File

@@ -105,4 +105,4 @@ Setting['verification_offices_url'] = 'http://oficinas-atencion-ciudadano.url/'
Setting['min_age_to_participate'] = 16 Setting['min_age_to_participate'] = 16
# Proposal improvement url path ('more-information/proposal-improvement') # Proposal improvement url path ('more-information/proposal-improvement')
Setting['proposal_improvement_url'] = nil Setting['proposal_improvement_path'] = nil

4
spec/features/proposals_spec.rb
View File

@@ -157,7 +157,7 @@ feature 'Proposals' do
end end
scenario 'Create with proposal improvement info link' do scenario 'Create with proposal improvement info link' do
Setting['proposal_improvement_url'] = 'more-information/proposal-improvement' Setting['proposal_improvement_path'] = 'more-information/proposal-improvement'
author = create(:user) author = create(:user)
login_as(author) login_as(author)
@@ -181,7 +181,7 @@ feature 'Proposals' do
expect(page).to have_content 'Help refugees' expect(page).to have_content 'Help refugees'
Setting['proposal_improvement_url'] = nil Setting['proposal_improvement_path'] = nil
end end
scenario 'Create with invisible_captcha honeypot field' do scenario 'Create with invisible_captcha honeypot field' do