From cf4e6d2c6486af54333c2809871b25ea2f7083f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 26 Mar 2021 04:22:56 +0100 Subject: [PATCH] Improve budget phase HTML ID Some browsers might not recognize an ID as valid when it starts with a number. --- app/components/budgets/phases_component.rb | 2 +- spec/system/budgets/budgets_spec.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/components/budgets/phases_component.rb b/app/components/budgets/phases_component.rb index ee23c7070..784770c94 100644 --- a/app/components/budgets/phases_component.rb +++ b/app/components/budgets/phases_component.rb @@ -21,7 +21,7 @@ class Budgets::PhasesComponent < ApplicationComponent end def phase_dom_id(phase) - "#{phases.index(phase) + 1}-#{phase.name.parameterize}" + "phase-#{phases.index(phase) + 1}-#{phase.name.parameterize}" end def prev_phase_dom_id(phase) diff --git a/spec/system/budgets/budgets_spec.rb b/spec/system/budgets/budgets_spec.rb index 90d48ffd0..b4a513b67 100644 --- a/spec/system/budgets/budgets_spec.rb +++ b/spec/system/budgets/budgets_spec.rb @@ -217,9 +217,9 @@ describe "Budgets" do click_link "Custom name for accepting phase" - within("#2-custom-name-for-accepting-phase") do - expect(page).to have_link("Previous phase", href: "#1-custom-name-for-informing-phase") - expect(page).to have_link("Next phase", href: "#3-custom-name-for-selecting-phase") + within("#phase-2-custom-name-for-accepting-phase") do + expect(page).to have_link "Previous phase", href: "#phase-1-custom-name-for-informing-phase" + expect(page).to have_link "Next phase", href: "#phase-3-custom-name-for-selecting-phase" end end