From ce1ee861f126c86c354098920fd186bce788dc9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 12 Apr 2024 03:08:10 +0200 Subject: [PATCH] Simplify "check all/none" buttons layout The float property was removed in commit b71c61e40, but then it was added again in commit 4a6313fed. It might have been necessary to do so back then because we had a `select` field instead of the links to set the order, but now, instead of making them float on the left and then make the next element clear the floats, we can do nothing and obtain the same results. --- app/assets/stylesheets/check_all_none.scss | 1 - app/views/moderation/budgets/investments/index.html.erb | 2 +- app/views/moderation/comments/index.html.erb | 2 +- app/views/moderation/debates/index.html.erb | 2 +- app/views/moderation/proposal_notifications/index.html.erb | 2 +- app/views/moderation/proposals/index.html.erb | 2 +- 6 files changed, 5 insertions(+), 6 deletions(-) diff --git a/app/assets/stylesheets/check_all_none.scss b/app/assets/stylesheets/check_all_none.scss index c06237a57..aeb8748c0 100644 --- a/app/assets/stylesheets/check_all_none.scss +++ b/app/assets/stylesheets/check_all_none.scss @@ -1,5 +1,4 @@ .check-all-none { - float: $global-left; list-style-type: none; margin-#{$global-left}: 0; diff --git a/app/views/moderation/budgets/investments/index.html.erb b/app/views/moderation/budgets/investments/index.html.erb index 1caf64927..4d81e5b98 100644 --- a/app/views/moderation/budgets/investments/index.html.erb +++ b/app/views/moderation/budgets/investments/index.html.erb @@ -1,5 +1,5 @@ <%= render Moderation::Shared::IndexComponent.new(@budget_investments) do %> - +
diff --git a/app/views/moderation/comments/index.html.erb b/app/views/moderation/comments/index.html.erb index 3e393ccdc..2381ce886 100644 --- a/app/views/moderation/comments/index.html.erb +++ b/app/views/moderation/comments/index.html.erb @@ -1,5 +1,5 @@ <%= render Moderation::Shared::IndexComponent.new(@comments) do %> -
<%= t("moderation.budget_investments.index.headers.budget_investment") %>
+
diff --git a/app/views/moderation/debates/index.html.erb b/app/views/moderation/debates/index.html.erb index ec8639581..a3f666764 100644 --- a/app/views/moderation/debates/index.html.erb +++ b/app/views/moderation/debates/index.html.erb @@ -1,5 +1,5 @@ <%= render Moderation::Shared::IndexComponent.new(@debates) do %> -
<%= t("moderation.comments.index.headers.comment") %>
+
diff --git a/app/views/moderation/proposal_notifications/index.html.erb b/app/views/moderation/proposal_notifications/index.html.erb index fd7821a42..2c8a71ac6 100644 --- a/app/views/moderation/proposal_notifications/index.html.erb +++ b/app/views/moderation/proposal_notifications/index.html.erb @@ -1,5 +1,5 @@ <%= render Moderation::Shared::IndexComponent.new(@proposal_notifications) do %> -
<%= t("moderation.debates.index.headers.debate") %>
+
diff --git a/app/views/moderation/proposals/index.html.erb b/app/views/moderation/proposals/index.html.erb index 766d590a3..387ab60d8 100644 --- a/app/views/moderation/proposals/index.html.erb +++ b/app/views/moderation/proposals/index.html.erb @@ -1,5 +1,5 @@ <%= render Moderation::Shared::IndexComponent.new(@proposals) do %> -
<%= t("moderation.proposal_notifications.index.headers.proposal_notification") %>
+
<%= t("moderation.proposals.index.headers.proposal") %>