From cb78a254f46eb882cd285059e88ab0e054b2cb6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 20 Nov 2020 17:25:36 +0100 Subject: [PATCH] Extract method to provide a title for SDG pages This way we'll avoid the duplication that can be found in the admin section. --- .../sdg_management/goals/index_component.html.erb | 6 +----- .../sdg_management/goals/index_component.rb | 2 ++ app/components/sdg_management/header.rb | 11 +++++++++++ 3 files changed, 14 insertions(+), 5 deletions(-) create mode 100644 app/components/sdg_management/header.rb diff --git a/app/components/sdg_management/goals/index_component.html.erb b/app/components/sdg_management/goals/index_component.html.erb index 2564b8dec..03d21e27d 100644 --- a/app/components/sdg_management/goals/index_component.html.erb +++ b/app/components/sdg_management/goals/index_component.html.erb @@ -1,8 +1,4 @@ -<% provide(:title) do %> - <%= t("sdg_management.header.title") %> - <%= title %> -<% end %> - -

<%= title %>

+<%= header %> diff --git a/app/components/sdg_management/goals/index_component.rb b/app/components/sdg_management/goals/index_component.rb index 9c7517861..7413be712 100644 --- a/app/components/sdg_management/goals/index_component.rb +++ b/app/components/sdg_management/goals/index_component.rb @@ -1,4 +1,6 @@ class SDGManagement::Goals::IndexComponent < ApplicationComponent + include SDGManagement::Header + attr_reader :goals def initialize(goals) diff --git a/app/components/sdg_management/header.rb b/app/components/sdg_management/header.rb new file mode 100644 index 000000000..0a9370031 --- /dev/null +++ b/app/components/sdg_management/header.rb @@ -0,0 +1,11 @@ +module SDGManagement::Header + extend ActiveSupport::Concern + + def header + provide(:title) do + "#{t("sdg_management.header.title")} - #{title}" + end + + tag.h2 title + end +end