From cb57b0c0c18d29a3d2e67e9a7145753c7e4bddc4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Wed, 9 Jul 2025 17:29:41 +0200
Subject: [PATCH] Extract methods in draft version form component

This way we don't get lines with 150+ characters.
---
 .../draft_versions/form_component.html.erb     | 10 ++--------
 .../draft_versions/form_component.rb           | 18 ++++++++++++++++++
 2 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/app/components/admin/legislation/draft_versions/form_component.html.erb b/app/components/admin/legislation/draft_versions/form_component.html.erb
index f2d187110..79cc3a4cd 100644
--- a/app/components/admin/legislation/draft_versions/form_component.html.erb
+++ b/app/components/admin/legislation/draft_versions/form_component.html.erb
@@ -1,12 +1,6 @@
 <%= render "shared/globalize_locales", resource: draft_version %>
 
-<%= translatable_form_for [:admin, process, draft_version], url: url,
-                                                            html: {
-                                                              data: {
-                                                                markdown_changes_message: I18n.t("admin.legislation.draft_versions.edit.markdown_changes_message")
-                                                              },
-                                                              class: "legislation-draft-versions-form"
-                                                            } do |f| %>
+<%= translatable_form_for [:admin, process, draft_version], form_attributes do |f| %>
   <%= render "shared/errors", resource: draft_version %>
 
   <div class="row">
@@ -81,7 +75,7 @@
     </div>
 
     <div class="small-12 medium-3 column clear end margin-top">
-      <%= f.submit(class: "button success expanded", value: t("admin.legislation.draft_versions.#{admin_submit_action(draft_version)}.submit_button")) %>
+      <%= f.submit(class: "button success expanded", value: submit_button_text) %>
     </div>
   </div>
 <% end %>
diff --git a/app/components/admin/legislation/draft_versions/form_component.rb b/app/components/admin/legislation/draft_versions/form_component.rb
index 8ecbf7311..ef90c4ebc 100644
--- a/app/components/admin/legislation/draft_versions/form_component.rb
+++ b/app/components/admin/legislation/draft_versions/form_component.rb
@@ -14,4 +14,22 @@ class Admin::Legislation::DraftVersions::FormComponent < ApplicationComponent
     def process
       draft_version.process
     end
+
+    def form_attributes
+      {
+        url: url,
+        html: {
+          data: { markdown_changes_message: markdown_changes_message },
+          class: "legislation-draft-versions-form"
+        }
+      }
+    end
+
+    def markdown_changes_message
+      I18n.t("admin.legislation.draft_versions.edit.markdown_changes_message")
+    end
+
+    def submit_button_text
+      t("admin.legislation.draft_versions.#{admin_submit_action(draft_version)}.submit_button")
+    end
 end