consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2887 from wairbut-m2c/backport/db_queries

Browse Source 
[Backport] Replace `.all.each` with `.find_each` to reduce memory usage
This commit is contained in:
Raimond Garcia
2018-09-17 19:06:46 +02:00
committed by GitHub
parent eb435930db ffe421ae69
commit cae210c155
11 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/welcome/_cards.html.erb
View File

@@ -1,7 +1,7 @@
<h3 class="title"><%= t("welcome.cards.title") %></h3>
<div class="row" data-equalizer data-equalizer-on="medium">
<% @cards.all.each do |card| %>
<% @cards.find_each do |card| %>
<%= render "card", card: card %>
<% end %>
</div>

4
db/dev_seeds/budgets.rb
View File

@@ -91,7 +91,7 @@ section "Marking investments as visible to valuators" do
end
section "Geolocating Investments" do
Budget.all.each do |budget|
Budget.find_each do |budget|
budget.investments.each do |investment|
MapLocation.create(latitude: Setting['map_latitude'].to_f + rand(-10..10)/100.to_f,
longitude: Setting['map_longitude'].to_f + rand(-10..10)/100.to_f,
@@ -140,7 +140,7 @@ section "Creating Valuation Assignments" do
end
section "Creating investment milestones" do
Budget::Investment.all.each do |investment|
Budget::Investment.find_each do |investment|
milestone = Budget::Investment::Milestone.new(investment_id: investment.id, publication_date: Date.tomorrow)
I18n.available_locales.map do |locale|
Globalize.with_locale(locale) do

6
db/dev_seeds/communities.rb
View File

@@ -1,10 +1,10 @@
section "Creating Communities" do
Proposal.all.each { |proposal| proposal.update(community: Community.create) }
Budget::Investment.all.each { |investment| investment.update(community: Community.create) }
Proposal.find_each { |proposal| proposal.update(community: Community.create) }
Budget::Investment.find_each { |investment| investment.update(community: Community.create) }
end
section "Creating Communities Topics" do
Community.all.each do |community|
Community.find_each do |community|
Topic.create(community: community, author: User.all.sample,
title: Faker::Lorem.sentence(3).truncate(60), description: Faker::Lorem.sentence)
end

2
db/dev_seeds/legislation_processes.rb
View File

@@ -23,7 +23,7 @@ section "Creating legislation processes" do
published: true)
end
Legislation::Process.all.each do |process|
Legislation::Process.find_each do |process|
(1..3).each do |i|
process.draft_versions.create!(title: "Version #{i}",
body: Faker::Lorem.paragraphs.join("\n\n"))

2
db/dev_seeds/notifications.rb
View File

@@ -1,5 +1,5 @@
section "Creating comment notifications" do
User.all.each do |user|
User.find_each do |user|
debate = Debate.create!(author: user,
title: Faker::Lorem.sentence(3).truncate(60),
description: "<p>#{Faker::Lorem.paragraphs.join('</p><p>')}</p>",

10
db/dev_seeds/polls.rb
View File

@@ -31,7 +31,7 @@ section "Creating polls" do
end
section "Creating Poll Questions & Answers" do
Poll.all.each do |poll|
Poll.find_each do |poll|
(1..4).to_a.sample.times do
question = Poll::Question.create!(author: User.all.sample,
title: Faker::Lorem.sentence(3).truncate(60) + '?',
@@ -55,10 +55,10 @@ section "Creating Poll Booths & BoothAssignments" do
end
section "Creating Poll Shifts for Poll Officers" do
Poll.all.each do |poll|
Poll.find_each do |poll|
Poll::BoothAssignment.where(poll: poll).each do |booth_assignment|
scrutiny = (poll.ends_at.to_datetime..poll.ends_at.to_datetime + Poll::RECOUNT_DURATION)
Poll::Officer.all.each do |poll_officer|
Poll::Officer.find_each do |poll_officer|
{
vote_collection: (poll.starts_at.to_datetime..poll.ends_at.to_datetime),
recount_scrutiny: scrutiny
@@ -130,7 +130,7 @@ section "Creating Poll Voters" do
end
section "Creating Poll Recounts" do
Poll.all.each do |poll|
Poll.find_each do |poll|
poll.booth_assignments.each do |booth_assignment|
officer_assignment = poll.officer_assignments.first
author = Poll::Officer.first.user
@@ -148,7 +148,7 @@ section "Creating Poll Recounts" do
end
section "Creating Poll Results" do
Poll.all.each do |poll|
Poll.find_each do |poll|
poll.booth_assignments.each do |booth_assignment|
officer_assignment = poll.officer_assignments.first
author = Poll::Officer.first.user

2
lib/tasks/slugs.rake
View File

@@ -2,7 +2,7 @@ namespace :slugs do
desc "Generate slug attribute for objects from classes that use Sluggable concern"
task generate: :environment do
%w(Budget Budget::Heading Budget::Group).each do |class_name|
class_name.constantize.all.each(&:generate_slug)
class_name.constantize.find_each(&:generate_slug)
end
end
end

2
spec/features/admin/admin_notifications_spec.rb
View File

@@ -199,7 +199,7 @@ feature "Admin Notifications" do
expect(page).to have_content "Notification sent successfully"
User.all.each do |user|
User.find_each do |user|
expect(user.notifications.count).to eq(1)
end
end

2
spec/features/admin/emails/newsletters_spec.rb
View File

@@ -41,7 +41,7 @@ feature "Admin newsletter emails" do
expect(page).to have_css(".newsletter", count: 3)
Newsletter.all.each do |newsletter|
Newsletter.find_each do |newsletter|
segment_recipient = I18n.t("admin.segment_recipient.#{newsletter.segment_recipient}")
within("#newsletter_#{newsletter.id}") do
expect(page).to have_content newsletter.subject

2
spec/features/admin/signature_sheets_spec.rb
View File

@@ -15,7 +15,7 @@ feature 'Signature sheets' do
expect(page).to have_css(".signature_sheet", count: 3)
SignatureSheet.all.each do |signature_sheet|
SignatureSheet.find_each do |signature_sheet|
expect(page).to have_content signature_sheet.name
end
end

2
spec/features/admin/stats_spec.rb
View File

@@ -131,7 +131,7 @@ feature 'Stats' do
expect(page).to have_css(".proposal_notification", count: 3)
ProposalNotification.all.each do |proposal_notification|
ProposalNotification.find_each do |proposal_notification|
expect(page).to have_content proposal_notification.title
expect(page).to have_content proposal_notification.body
end