From ca4a0bd4b230e1551f0302598e52cf269b8603d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 5 May 2022 12:49:44 +0200 Subject: [PATCH] Use "login details" instead of "credentials" As suggested by Pomerange, "credentials" also refers to academic qualifications, and so might be confusing. --- config/locales/en/general.yml | 2 +- spec/system/account_spec.rb | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/config/locales/en/general.yml b/config/locales/en/general.yml index 215ea9020..fb672e02f 100644 --- a/config/locales/en/general.yml +++ b/config/locales/en/general.yml @@ -1,7 +1,7 @@ en: account: show: - change_credentials_link: Change my credentials + change_credentials_link: Change my login details erase_account_link: Erase my account finish_verification: Complete verification notifications: Notifications diff --git a/spec/system/account_spec.rb b/spec/system/account_spec.rb index f1d0ea301..ed1ab76b9 100644 --- a/spec/system/account_spec.rb +++ b/spec/system/account_spec.rb @@ -53,7 +53,7 @@ describe "Account" do scenario "Edit email address" do visit account_path - click_link "Change my credentials" + click_link "Change my login details" fill_in "user_email", with: "new_user_email@example.com" fill_in "user_password", with: "new_password" fill_in "user_password_confirmation", with: "new_password" @@ -80,7 +80,7 @@ describe "Account" do expect(page).to have_content "You have been signed in successfully." visit account_path - click_link "Change my credentials" + click_link "Change my login details" expect(page).to have_selector("input[value='new_user_email@example.com']") end @@ -150,8 +150,7 @@ describe "Account" do expect(page).to have_current_path(account_path, ignore_query: true) - expect(page).to have_link("Change my credentials") - click_link "Change my credentials" + click_link "Change my login details" click_button "Update" expect(page).to have_content error_message