From ca3d759d9f1216d600acb40d2ec3b4e65f8ab187 Mon Sep 17 00:00:00 2001
From: Bertocq <bertocq@gmail.com>
Date: Mon, 15 Jan 2018 20:20:10 +0100
Subject: [PATCH] Refactor Budget publishing prices phases constant to
 Budget::Phase model

---
 app/models/budget.rb                      | 4 +---
 app/models/budget/phase.rb                | 1 +
 spec/features/budgets/investments_spec.rb | 4 ++--
 spec/models/budget/investment_spec.rb     | 8 ++++----
 4 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/app/models/budget.rb b/app/models/budget.rb
index fc65938d1..bf64c0fd6 100644
--- a/app/models/budget.rb
+++ b/app/models/budget.rb
@@ -3,8 +3,6 @@ class Budget < ActiveRecord::Base
   include Measurable
   include Sluggable
 
-  PUBLISHED_PRICES_PHASES = %w(publishing_prices balloting reviewing_ballots finished).freeze
-
   CURRENCY_SYMBOLS = %w(€ $ £ ¥).freeze
 
   validates :name, presence: true, uniqueness: true
@@ -80,7 +78,7 @@ class Budget < ActiveRecord::Base
   end
 
   def published_prices?
-    PUBLISHED_PRICES_PHASES.include?(phase)
+    Budget::Phase::PUBLISHED_PRICES_PHASES.include?(phase)
   end
 
   def balloting_process?
diff --git a/app/models/budget/phase.rb b/app/models/budget/phase.rb
index 634dbc666..c55f6a636 100644
--- a/app/models/budget/phase.rb
+++ b/app/models/budget/phase.rb
@@ -2,6 +2,7 @@ class Budget
   class Phase < ActiveRecord::Base
     PHASE_KINDS = %w(drafting accepting reviewing selecting valuating publishing_prices balloting
                 reviewing_ballots finished).freeze
+    PUBLISHED_PRICES_PHASES = %w(publishing_prices balloting reviewing_ballots finished).freeze
     DESCRIPTION_MAX_LENGTH = 2000
 
     belongs_to :budget
diff --git a/spec/features/budgets/investments_spec.rb b/spec/features/budgets/investments_spec.rb
index 0e8dc859a..7569d96bc 100644
--- a/spec/features/budgets/investments_spec.rb
+++ b/spec/features/budgets/investments_spec.rb
@@ -426,7 +426,7 @@ feature 'Budget Investments' do
     context "When investment with price is selected" do
 
       scenario "Price & explanation is shown when Budget is on published prices phase" do
-        Budget::PUBLISHED_PRICES_PHASES.each do |phase|
+        Budget::Phase::PUBLISHED_PRICES_PHASES.each do |phase|
           budget.update(phase: phase)
           visit budget_investment_path(budget_id: budget.id, id: investment.id)
 
@@ -440,7 +440,7 @@ feature 'Budget Investments' do
       end
 
       scenario "Price & explanation isn't shown when Budget is not on published prices phase" do
-        (Budget::Phase::PHASE_KINDS - Budget::PUBLISHED_PRICES_PHASES).each do |phase|
+        (Budget::Phase::PHASE_KINDS - Budget::Phase::PUBLISHED_PRICES_PHASES).each do |phase|
           budget.update(phase: phase)
           visit budget_investment_path(budget_id: budget.id, id: investment.id)
 
diff --git a/spec/models/budget/investment_spec.rb b/spec/models/budget/investment_spec.rb
index 4ca0b1d5f..7fbb46039 100644
--- a/spec/models/budget/investment_spec.rb
+++ b/spec/models/budget/investment_spec.rb
@@ -200,7 +200,7 @@ describe Budget::Investment do
     end
 
     it "returns true for selected investments which budget's phase is publishing_prices or later" do
-      Budget::PUBLISHED_PRICES_PHASES.each do |phase|
+      Budget::Phase::PUBLISHED_PRICES_PHASES.each do |phase|
         budget.update(phase: phase)
 
         expect(investment.should_show_price?).to eq(true)
@@ -208,7 +208,7 @@ describe Budget::Investment do
     end
 
     it "returns false in any other phase" do
-      (Budget::Phase::PHASE_KINDS - Budget::PUBLISHED_PRICES_PHASES).each do |phase|
+      (Budget::Phase::PHASE_KINDS - Budget::Phase::PUBLISHED_PRICES_PHASES).each do |phase|
         budget.update(phase: phase)
 
         expect(investment.should_show_price?).to eq(false)
@@ -235,7 +235,7 @@ describe Budget::Investment do
     end
 
     it "returns true for selected with price_explanation & budget in publishing_prices or later" do
-      Budget::PUBLISHED_PRICES_PHASES.each do |phase|
+      Budget::Phase::PUBLISHED_PRICES_PHASES.each do |phase|
         budget.update(phase: phase)
 
         expect(investment.should_show_price_explanation?).to eq(true)
@@ -243,7 +243,7 @@ describe Budget::Investment do
     end
 
     it "returns false in any other phase" do
-      (Budget::Phase::PHASE_KINDS - Budget::PUBLISHED_PRICES_PHASES).each do |phase|
+      (Budget::Phase::PHASE_KINDS - Budget::Phase::PUBLISHED_PRICES_PHASES).each do |phase|
         budget.update(phase: phase)
 
         expect(investment.should_show_price_explanation?).to eq(false)