From 9a4d6750fc5d8f3ed132e220a97a8cf26ec729be Mon Sep 17 00:00:00 2001
From: rgarcia <voodoorai2000@gmail.com>
Date: Mon, 15 Jan 2018 23:41:37 +0100
Subject: [PATCH 1/4] Clean up asset precompilation output from travis logs

Asset precompilation generates a lot of logs, making it slower to
scroll down to see the commonly relevant information, knowing what spec
has failed

Redirecting standard error and standard output to dev/null helps reach
this information faster
---
 .travis.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index 63d0a194f..a971bb8b1 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -9,8 +9,8 @@ before_script:
 - for i in config/*.example; do cp "$i" "${i/.example}"; done
 - bundle exec rake db:setup
 script:
-- bundle exec rake assets:precompile RAILS_ENV=test
-- bin/knapsack_pro_rspec
+  - "bundle exec rake assets:precompile RAILS_ENV=test > /dev/null 2>&1"
+  - "bin/knapsack_pro_rspec"
 env:
   global:
   - KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true

From 398cdd2d4c212b626a86097bfcd9b6d44182a7dc Mon Sep 17 00:00:00 2001
From: rgarcia <voodoorai2000@gmail.com>
Date: Mon, 15 Jan 2018 23:47:04 +0100
Subject: [PATCH 2/4] Reduce travis' knapsack log level to info

---
 .travis.yml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index a971bb8b1..97c41c1a7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -9,11 +9,12 @@ before_script:
 - for i in config/*.example; do cp "$i" "${i/.example}"; done
 - bundle exec rake db:setup
 script:
-  - "bundle exec rake assets:precompile RAILS_ENV=test > /dev/null 2>&1"
-  - "bin/knapsack_pro_rspec"
+- "bundle exec rake assets:precompile RAILS_ENV=test > /dev/null 2>&1"
+- "bin/knapsack_pro_rspec"
 env:
   global:
   - KNAPSACK_PRO_FIXED_QUEUE_SPLIT=true
+  - KNAPSACK_PRO_LOG_LEVEL=info
   - KNAPSACK_PRO_CI_NODE_TOTAL=2
   matrix:
   - KNAPSACK_PRO_CI_NODE_INDEX=0

From 8fb9be9d0782109d594ed1aca68eb61713dcd9a6 Mon Sep 17 00:00:00 2001
From: rgarcia <voodoorai2000@gmail.com>
Date: Tue, 16 Jan 2018 00:00:52 +0100
Subject: [PATCH 3/4] Fix RSpec's `should` deprecation warning

Using `stub` from rspec-mocks' old `:should` syntax without explicitly
enabling the syntax is deprecated. Use the new `:expect` syntax or
explicitly enable `:should` instead
---
 spec/features/polls/voter_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/features/polls/voter_spec.rb b/spec/features/polls/voter_spec.rb
index 396b18341..75406ccca 100644
--- a/spec/features/polls/voter_spec.rb
+++ b/spec/features/polls/voter_spec.rb
@@ -29,7 +29,7 @@ feature "Voter" do
         expect(page).not_to have_link(answer_yes.title)
       end
 
-      expect(find(:css, ".js-token-message")).to be_visible
+      expect(page).to have_css(".js-token-message", visible: true)
       token = find(:css, ".js-question-answer")[:href].gsub(/.+?(?=token)/, '').gsub('token=', '')
 
       expect(page).to have_content "You can write down this vote identifier, to check your vote on the final results: #{token}"

From e456f5fc1c788ae80ebedeee3987ca5ea137254d Mon Sep 17 00:00:00 2001
From: rgarcia <voodoorai2000@gmail.com>
Date: Tue, 16 Jan 2018 00:18:07 +0100
Subject: [PATCH 4/4] Remove duplicate dev_seed execution

---
 spec/lib/tasks/dev_seed_spec.rb | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/spec/lib/tasks/dev_seed_spec.rb b/spec/lib/tasks/dev_seed_spec.rb
index 901a9f541..0ac28203e 100644
--- a/spec/lib/tasks/dev_seed_spec.rb
+++ b/spec/lib/tasks/dev_seed_spec.rb
@@ -2,13 +2,7 @@ require 'rails_helper'
 require 'rake'
 
 describe 'rake db:dev_seed' do
-  before do
-    Rake.application.rake_require('tasks/db')
-    Rake::Task.define_task(:environment)
-  end
-
   let :run_rake_task do
-    Rake::Task['db:dev_seed'].reenable
     Rake.application.invoke_task('db:dev_seed')
   end