consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace Partials with Direct Component Rendering

Browse Source 
In this commit, we have performed a refactoring to enhance code organization.
Several partials that were solely responsible for rendering components have been removed.

Instead, we are now directly rendering the components within the views where these
partials were previously used.
This commit is contained in:
taitus
2023-09-20 11:52:52 +02:00
parent 5009bf6c37
commit c96e3b027f
8 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/comments/_comment.html.erb
View File

@@ -81,7 +81,7 @@
<div id="<%= dom_id(comment) %>_reply" class="reply">
<% unless valuation %>
<div id="<%= dom_id(comment) %>_votes" class="comment-votes float-right">
<%= render "comments/votes", comment: comment %>
<%= render Comments::VotesComponent.new(comment) %>
</div>
<% end %>

1
app/views/comments/_votes.html.erb
View File

@@ -1 +0,0 @@
<%= render Comments::VotesComponent.new(comment) %>

2
app/views/comments/vote.js.erb
View File

@@ -1 +1 @@
$("#<%= dom_id(@comment) %>_votes").html("<%= j render("comments/votes", comment: @comment) %>");
$("#<%= dom_id(@comment) %>_votes").html("<%= j render Comments::VotesComponent.new(@comment) %>");

2
app/views/debates/_debate.html.erb
View File

@@ -49,7 +49,7 @@
</div>
<div id="<%= dom_id(debate) %>_votes" class="small-12 medium-3 column">
<%= render "debates/votes", debate: debate %>
<%= render Debates::VotesComponent.new(debate) %>
</div>
</div>

1
app/views/debates/_votes.html.erb
View File

@@ -1 +0,0 @@
<%= render Debates::VotesComponent.new(debate) %>

2
app/views/debates/show.html.erb
View File

@@ -57,7 +57,7 @@
<div class="sidebar-divider"></div>
<h2><%= t("votes.supports") %></h2>
<div id="<%= dom_id(@debate) %>_votes">
<%= render "debates/votes", debate: @debate %>
<%= render Debates::VotesComponent.new(@debate) %>
</div>
<%= render "shared/social_share",
share_title: t("debates.show.share"),

2
app/views/debates/vote.js.erb
View File

@@ -1 +1 @@
$("#<%= dom_id(@debate) %>_votes").html("<%= j render("debates/votes", debate: @debate) %>");
$("#<%= dom_id(@debate) %>_votes").html("<%= j render Debates::VotesComponent.new(@debate) %>");

2
app/views/legislation/annotations/_comments.html.erb
View File

@@ -24,7 +24,7 @@
</div>
<div class="comment-votes">
<div id="<%= dom_id(comment) %>_votes" class="comment-votes float-right">
<%= render "comments/votes", comment: comment %>
<%= render Comments::VotesComponent.new(comment) %>
</div>
</div>
</div>