Merge pull request #5173 from consuldemocracy/budget_results

Replace back link on budget results
This commit is contained in:
Sebastia
2023-11-14 10:08:31 +01:00
committed by GitHub
6 changed files with 21 additions and 3 deletions

View File

@@ -15,7 +15,7 @@
<div class="expanded no-margin-top padding header"> <div class="expanded no-margin-top padding header">
<div class="row"> <div class="row">
<div class="small-12 column"> <div class="small-12 column">
<%= back_link_to budgets_path %> <%= back_link_to budget_path(@budget) %>
<h2 class="margin-top"> <h2 class="margin-top">
<%= t("budgets.executions.heading") %><br> <%= t("budgets.executions.heading") %><br>
<span><%= @budget.name %></span> <span><%= @budget.name %></span>

View File

@@ -14,7 +14,7 @@
<div class="expanded no-margin-top padding header"> <div class="expanded no-margin-top padding header">
<div class="row"> <div class="row">
<div class="small-12 column"> <div class="small-12 column">
<%= back_link_to budgets_path %> <%= back_link_to budget_path(@budget) %>
<h2 class="margin-top"> <h2 class="margin-top">
<%= t("budgets.results.heading") %><br> <%= t("budgets.results.heading") %><br>
<span><%= @budget.name %></span> <span><%= @budget.name %></span>

View File

@@ -12,7 +12,7 @@
<div class="expanded no-margin-top padding header"> <div class="expanded no-margin-top padding header">
<div class="row"> <div class="row">
<div class="small-12 column"> <div class="small-12 column">
<%= back_link_to budgets_path %> <%= back_link_to budget_path(@budget) %>
<h2 class="margin-top"> <h2 class="margin-top">
<%= t("stats.title") %><br> <%= t("stats.title") %><br>
<span><%= @budget.name %></span> <span><%= @budget.name %></span>

View File

@@ -76,6 +76,12 @@ describe "Executions" do
expect(page).to have_content("No winner investments in this state") expect(page).to have_content("No winner investments in this state")
end end
scenario "Back link redirects to budget page" do
visit budget_executions_path(budget)
expect(page).to have_link("Go back", href: budget_path(budget))
end
context "Images" do context "Images" do
scenario "renders milestone image if available" do scenario "renders milestone image if available" do
milestone1 = create(:milestone, :with_image, milestoneable: investment1) milestone1 = create(:milestone, :with_image, milestoneable: investment1)

View File

@@ -28,6 +28,12 @@ describe "Results" do
Budget::Result.new(budget, heading).calculate_winners Budget::Result.new(budget, heading).calculate_winners
end end
scenario "Back link redirects to budget page" do
visit budget_results_path(budget)
expect(page).to have_link("Go back", href: budget_path(budget))
end
scenario "No links to budget results with results disabled" do scenario "No links to budget results with results disabled" do
budget.update!(results_enabled: false) budget.update!(results_enabled: false)

View File

@@ -30,5 +30,11 @@ describe "Stats" do
expect(page).not_to have_content "Advanced statistics" expect(page).not_to have_content "Advanced statistics"
end end
end end
scenario "Back link redirects to budget page" do
visit budget_stats_path(budget)
expect(page).to have_link("Go back", href: budget_path(budget))
end
end end
end end