Simplify map location coordinates helpers
We're calling this method after setting the map location with `map_location = MapLocation.new if map_location.nil?`, so the condition `map_location.present?` is always going to be true.
This commit is contained in:
@@ -4,15 +4,15 @@ module MapLocationsHelper
|
||||
end
|
||||
|
||||
def map_location_latitude(map_location)
|
||||
map_location.present? && map_location.latitude.present? ? map_location.latitude : Setting["map.latitude"]
|
||||
map_location.latitude.presence || Setting["map.latitude"]
|
||||
end
|
||||
|
||||
def map_location_longitude(map_location)
|
||||
map_location.present? && map_location.longitude.present? ? map_location.longitude : Setting["map.longitude"]
|
||||
map_location.longitude.presence || Setting["map.longitude"]
|
||||
end
|
||||
|
||||
def map_location_zoom(map_location)
|
||||
map_location.present? && map_location.zoom.present? ? map_location.zoom : Setting["map.zoom"]
|
||||
map_location.zoom.presence || Setting["map.zoom"]
|
||||
end
|
||||
|
||||
def map_location_input_id(prefix, attribute)
|
||||
|
||||
Reference in New Issue
Block a user