From c5059f7292d52d653d5cd1874f885685aa9640f3 Mon Sep 17 00:00:00 2001 From: Bertocq Date: Mon, 25 Sep 2017 22:46:09 +0200 Subject: [PATCH] Fix Style/ParenthesesAroundCondition rubocop issues --- .rubocop_todo.yml | 9 --------- app/models/debate.rb | 2 +- app/models/proposal.rb | 2 +- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7fe5ee343..1b2b7411e 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -625,15 +625,6 @@ Style/ParallelAssignment: - 'lib/active_model/dates.rb' - 'spec/support/common_actions.rb' -# Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: AllowSafeAssignment. -Style/ParenthesesAroundCondition: - Exclude: - - 'app/controllers/proposals_controller.rb' - - 'app/models/debate.rb' - - 'app/models/proposal.rb' - # Offense count: 11 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist. # NamePrefix: is_, has_, have_ diff --git a/app/models/debate.rb b/app/models/debate.rb index 9d74597b8..96c723db2 100644 --- a/app/models/debate.rb +++ b/app/models/debate.rb @@ -88,7 +88,7 @@ class Debate < ActiveRecord::Base def register_vote(user, vote_value) if votable_by?(user) - Debate.increment_counter(:cached_anonymous_votes_total, id) if (user.unverified? && !user.voted_for?(self)) + Debate.increment_counter(:cached_anonymous_votes_total, id) if user.unverified? && !user.voted_for?(self) vote_by(voter: user, vote: vote_value) end end diff --git a/app/models/proposal.rb b/app/models/proposal.rb index f9eeecc6f..bce8b9af2 100644 --- a/app/models/proposal.rb +++ b/app/models/proposal.rb @@ -88,7 +88,7 @@ class Proposal < ActiveRecord::Base def self.search_by_code(terms) matched_code = match_code(terms) results = where(id: matched_code[1]) if matched_code - return results if (results.present? && results.first.code == terms) + return results if results.present? && results.first.code == terms end def self.match_code(terms)