refactors pending verification step view [#500]

app/models/concerns/verification.rb

@@ -45,4 +45,15 @@ module Verification
     !level_two_or_three_verified?
   end
 
+  def failed_residence_verification?
+    !residence_verified? && failed_census_calls.size > 0
+  end
+
+  def no_phone_available?
+    !verification_sms_sent?
+  end
+
+  def sms_code_not_confirmed?
+    !sms_verified?
+  end
 end

app/views/admin/verifications/_pending_step.html.erb

@@ -1,7 +1,7 @@
-<% if !user.residence_verified? %>
+<% if user.failed_residence_verification? %>
   <%= render partial: 'failed_census_call', collection: user.failed_census_calls %>
-<% elsif !user.verification_sms_sent? %>
+<% elsif user.no_phone_available? %>
   <p><%= t("admin.verifications.index.phone_not_given") %></p>
-<% elsif !user.sms_verified? %>
+<% elsif user.sms_code_not_confirmed? %>
   <p><%= t("admin.verifications.index.sms_code_not_confirmed") %></p>
 <% end %>