From bfd39a13e0840f63c17e7768415493ede7ad6443 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 26 Sep 2019 00:31:47 +0200 Subject: [PATCH] Remove unnecessary attributes in proposals spec These tests are only checking which proposals are not included in the recommendations, so we don't need to sort the included ones, just like we don't use the cached votes up attribute in the tests preceeding these ones. --- spec/features/proposals_spec.rb | 2 +- spec/models/proposal_spec.rb | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/spec/features/proposals_spec.rb b/spec/features/proposals_spec.rb index 2fd156fbc..34f903359 100644 --- a/spec/features/proposals_spec.rb +++ b/spec/features/proposals_spec.rb @@ -997,7 +997,7 @@ describe "Proposals" do end scenario "do not show recommented proposal in selected proposals list" do - create(:proposal, title: "Recommended", cached_votes_up: 10, tag_list: "Economy") + create(:proposal, title: "Recommended", tag_list: "Economy") user = create(:user) create(:follow, followable: create(:proposal, tag_list: "Economy"), user: user) diff --git a/spec/models/proposal_spec.rb b/spec/models/proposal_spec.rb index 359ddd07c..7ff4b40be 100644 --- a/spec/models/proposal_spec.rb +++ b/spec/models/proposal_spec.rb @@ -1031,8 +1031,8 @@ describe Proposal do end it "does not return archived proposals" do - proposal1 = create(:proposal, cached_votes_up: 5, tag_list: "Sport") - proposal2 = create(:proposal, cached_votes_up: 5, tag_list: "Sport") + proposal1 = create(:proposal, tag_list: "Sport") + proposal2 = create(:proposal, tag_list: "Sport") archived_proposal = create(:proposal, :archived, tag_list: "Sport") create(:follow, followable: proposal1, user: user) @@ -1042,9 +1042,9 @@ describe Proposal do end it "does not return already supported proposals" do - proposal1 = create(:proposal, cached_votes_up: 5, tag_list: "Health") - proposal2 = create(:proposal, cached_votes_up: 5, tag_list: "Health") - proposal3 = create(:proposal, cached_votes_up: 5, tag_list: "Health") + proposal1 = create(:proposal, tag_list: "Health") + proposal2 = create(:proposal, tag_list: "Health") + proposal3 = create(:proposal, tag_list: "Health") create(:vote, votable: proposal1, voter: user) create(:follow, followable: proposal2, user: user)