fixes spacing

This commit is contained in:
rgarcia
2015-08-16 22:45:43 +02:00
parent 57530926a1
commit bea38226fe
17 changed files with 72 additions and 72 deletions

View File

@@ -16,6 +16,7 @@ class AccountController < ApplicationController
end end
private private
def set_account def set_account
@account = current_user @account = current_user
end end

View File

@@ -10,4 +10,4 @@ class Admin::BaseController < ApplicationController
raise CanCan::AccessDenied unless current_user.try(:administrator?) raise CanCan::AccessDenied unless current_user.try(:administrator?)
end end
end end

View File

@@ -26,12 +26,12 @@ class Admin::TagsController < Admin::BaseController
private private
def tag_params def tag_params
params.require(:tag).permit(:featured, :name) params.require(:tag).permit(:featured, :name)
end end
def find_tag def find_tag
@tag = ActsAsTaggableOn::Tag.find(params[:id]) @tag = ActsAsTaggableOn::Tag.find(params[:id])
end end
end end

View File

@@ -19,25 +19,25 @@ class ApplicationController < ActionController::Base
private private
def set_locale def set_locale
if params[:locale] && I18n.available_locales.include?(params[:locale].to_sym) if params[:locale] && I18n.available_locales.include?(params[:locale].to_sym)
session[:locale] = params[:locale] session[:locale] = params[:locale]
end
session[:locale] ||= I18n.default_locale
I18n.locale = session[:locale]
end end
session[:locale] ||= I18n.default_locale def set_layout
if devise_controller?
I18n.locale = session[:locale] "devise"
end else
"application"
def set_layout end
if devise_controller?
"devise"
else
"application"
end end
end
def set_debate_votes(debates) def set_debate_votes(debates)
@voted_values = current_user ? current_user.debate_votes(debates) : {} @voted_values = current_user ? current_user.debate_votes(debates) : {}
end end
end end

View File

@@ -22,6 +22,7 @@ class CommentsController < ApplicationController
end end
private private
def comment_params def comment_params
params.require(:comments).permit(:commentable_type, :commentable_id, :body) params.require(:comments).permit(:commentable_type, :commentable_id, :body)
end end

View File

@@ -48,6 +48,7 @@ class DebatesController < ApplicationController
private private
def debate_params def debate_params
params.require(:debate).permit(:title, :description, :tag_list, :terms_of_service, :captcha, :captcha_key) params.require(:debate).permit(:title, :description, :tag_list, :terms_of_service, :captcha, :captcha_key)
end end

View File

@@ -12,8 +12,8 @@ class RegistrationsController < Devise::RegistrationsController
private private
def sign_up_params def sign_up_params
params.require(:user).permit(:first_name, :last_name, :email, :password, :password_confirmation, :use_nickname, :nickname, :captcha, :captcha_key) params.require(:user).permit(:first_name, :last_name, :email, :password, :password_confirmation, :use_nickname, :nickname, :captcha, :captcha_key)
end end
end end

View File

@@ -3,7 +3,7 @@ class Debate < ActiveRecord::Base
default_scope { order('created_at DESC') } default_scope { order('created_at DESC') }
apply_simple_captcha apply_simple_captcha
TITLE_LENGTH = Debate.columns.find{|c| c.name == 'title'}.limit TITLE_LENGTH = Debate.columns.find { |c| c.name == 'title' }.limit
acts_as_votable acts_as_votable
acts_as_commentable acts_as_commentable
@@ -70,7 +70,7 @@ class Debate < ActiveRecord::Base
end end
def sanitize_tag_list def sanitize_tag_list
self.tag_list = TagSanitizer.new.sanitize_tag_list(self.tag_list) self.tag_list = TagSanitizer.new.sanitize_tag_list(self.tag_list)
end end
end end

View File

@@ -15,7 +15,7 @@ class User < ActiveRecord::Base
def debate_votes(debates) def debate_votes(debates)
voted = votes.for_debates.in(debates) voted = votes.for_debates.in(debates)
voted.each_with_object({}) { |v,_| _[v.votable_id] = v.value } voted.each_with_object({}) { |v, _| _[v.votable_id] = v.value }
end end
def administrator? def administrator?

View File

@@ -9,15 +9,15 @@ FactoryGirl.define do
end end
factory :debate do factory :debate do
sequence(:title) {|n| "Debate #{n} title"} sequence(:title) { |n| "Debate #{n} title" }
description 'Debate description' description 'Debate description'
terms_of_service '1' terms_of_service '1'
association :author, factory: :user association :author, factory: :user
end end
factory :vote do factory :vote do
association :votable, factory: :debate association :votable, factory: :debate
association :voter, factory: :user association :voter, factory: :user
vote_flag true vote_flag true
end end
@@ -36,7 +36,7 @@ FactoryGirl.define do
end end
factory :tag, class: 'ActsAsTaggableOn::Tag' do factory :tag, class: 'ActsAsTaggableOn::Tag' do
sequence(:name) {|n| "Tag #{n} name"} sequence(:name) { |n| "Tag #{n} name" }
trait :featured do trait :featured do
featured true featured true

View File

@@ -3,7 +3,7 @@ require 'rails_helper'
feature 'Account' do feature 'Account' do
background do background do
@user = create(:user, first_name: "Manuela", last_name:"Colau") @user = create(:user, first_name: "Manuela", last_name: "Colau")
login_as(@user) login_as(@user)
end end

View File

@@ -26,7 +26,7 @@ feature 'Comments' do
visit debate_path(debate) visit debate_path(debate)
expect(page).to have_content 'Log in to participate' expect(page).to have_content 'Log in to participate'
within ('#comments') do within('#comments') do
expect(page).to_not have_content 'Write a comment' expect(page).to_not have_content 'Write a comment'
expect(page).to_not have_content 'Reply' expect(page).to_not have_content 'Reply'
expect(page).to_not have_css('form') expect(page).to_not have_css('form')
@@ -77,7 +77,7 @@ feature 'Comments' do
click_button 'Publish reply' click_button 'Publish reply'
end end
within "#comment-#{comment.id}" do within("#comment-#{comment.id}") do
expect(page).to have_content 'It will be done next week.' expect(page).to have_content 'It will be done next week.'
end end

View File

@@ -98,7 +98,7 @@ feature 'Debates' do
visit new_debate_path visit new_debate_path
click_button 'Create Debate' click_button 'Create Debate'
expect(page).to have_content /error/ expect(page).to have_content error_message
end end
scenario 'JS injection is prevented but safe html is respected' do scenario 'JS injection is prevented but safe html is respected' do
@@ -183,7 +183,7 @@ feature 'Debates' do
scenario 'Update should not be posible if debate is not editable' do scenario 'Update should not be posible if debate is not editable' do
debate = create(:debate) debate = create(:debate)
vote = create(:vote, votable: debate) create(:vote, votable: debate)
expect(debate).to_not be_editable expect(debate).to_not be_editable
login_as(debate.author) login_as(debate.author)
@@ -223,7 +223,7 @@ feature 'Debates' do
end end
scenario 'Captcha is required to update a debate' do scenario 'Captcha is required to update a debate' do
debate = create(:debate) debate = create(:debate)
login_as(debate.author) login_as(debate.author)
visit edit_debate_path(debate) visit edit_debate_path(debate)
@@ -264,12 +264,9 @@ feature 'Debates' do
end end
describe 'Limiting tags shown' do describe 'Limiting tags shown' do
let(:all_tags) { tags = ["Hacienda", "Economía", "Medio Ambiente", "Corrupción", "Fiestas populares", "Prensa", "Huelgas"]
["Hacienda", "Economía", "Medio Ambiente", "Corrupción", "Fiestas populares", "Prensa", "Huelgas"] let(:all_tags) { tags }
} let(:debate) { create :debate, tag_list: all_tags }
let(:debate) {
create :debate, tag_list: all_tags
}
scenario 'Index page shows up to 5 tags per debate' do scenario 'Index page shows up to 5 tags per debate' do
debate debate
@@ -287,7 +284,7 @@ feature 'Debates' do
scenario 'Index page shows 3 tags with no plus link' do scenario 'Index page shows 3 tags with no plus link' do
tag_list = ["Medio Ambiente", "Corrupción", "Fiestas populares"] tag_list = ["Medio Ambiente", "Corrupción", "Fiestas populares"]
debate = create :debate, tag_list: tag_list create :debate, tag_list: tag_list
visit debates_path visit debates_path

View File

@@ -32,7 +32,7 @@ feature 'Users' do
end end
scenario 'Sign in' do scenario 'Sign in' do
user = create(:user, email: 'manuela@madrid.es', password: 'judgementday') create(:user, email: 'manuela@madrid.es', password: 'judgementday')
visit '/' visit '/'
click_link 'Log in' click_link 'Log in'

View File

@@ -17,8 +17,8 @@ feature 'Votes' do
debate1 = create(:debate) debate1 = create(:debate)
debate2 = create(:debate) debate2 = create(:debate)
debate3 = create(:debate) debate3 = create(:debate)
vote = create(:vote, voter: @manuela, votable: debate1, vote_flag: true) create(:vote, voter: @manuela, votable: debate1, vote_flag: true)
vote = create(:vote, voter: @manuela, votable: debate3, vote_flag: false) create(:vote, voter: @manuela, votable: debate3, vote_flag: false)
visit root_path visit root_path
@@ -65,8 +65,8 @@ feature 'Votes' do
debate1 = create(:debate) debate1 = create(:debate)
debate2 = create(:debate) debate2 = create(:debate)
debate3 = create(:debate) debate3 = create(:debate)
vote = create(:vote, voter: @manuela, votable: debate1, vote_flag: true) create(:vote, voter: @manuela, votable: debate1, vote_flag: true)
vote = create(:vote, voter: @manuela, votable: debate3, vote_flag: false) create(:vote, voter: @manuela, votable: debate3, vote_flag: false)
visit debates_path visit debates_path
@@ -120,7 +120,7 @@ feature 'Votes' do
expect(page).to_not have_css("a.no-voted") expect(page).to_not have_css("a.no-voted")
end end
within('.against') do within('.against') do
expect(page).to have_content "0%" expect(page).to have_content "0%"
expect(page).to_not have_css("a.voted") expect(page).to_not have_css("a.voted")
expect(page).to_not have_css("a.no-voted") expect(page).to_not have_css("a.no-voted")
@@ -128,8 +128,8 @@ feature 'Votes' do
end end
scenario 'Show' do scenario 'Show' do
vote = create(:vote, voter: @manuela, votable: @debate, vote_flag: true) create(:vote, voter: @manuela, votable: @debate, vote_flag: true)
vote = create(:vote, voter: @pablo, votable: @debate, vote_flag: false) create(:vote, voter: @pablo, votable: @debate, vote_flag: false)
visit debate_path(@debate) visit debate_path(@debate)
@@ -140,7 +140,7 @@ feature 'Votes' do
expect(page).to have_css("a.voted") expect(page).to have_css("a.voted")
end end
within('.against') do within('.against') do
expect(page).to have_content "50%" expect(page).to have_content "50%"
expect(page).to have_css("a.no-voted") expect(page).to have_css("a.no-voted")
end end
@@ -154,7 +154,7 @@ feature 'Votes' do
expect(page).to have_css("a.voted") expect(page).to have_css("a.voted")
end end
within('.against') do within('.against') do
expect(page).to have_content "0%" expect(page).to have_content "0%"
expect(page).to have_css("a.no-voted") expect(page).to have_css("a.no-voted")
end end
@@ -173,7 +173,7 @@ feature 'Votes' do
expect(page).to have_css("a.voted") expect(page).to have_css("a.voted")
end end
within('.against') do within('.against') do
expect(page).to have_content "0%" expect(page).to have_content "0%"
expect(page).to have_css("a.no-voted") expect(page).to have_css("a.no-voted")
end end
@@ -195,7 +195,7 @@ feature 'Votes' do
expect(page).to have_css("a.voted") expect(page).to have_css("a.voted")
end end
within('.against') do within('.against') do
expect(page).to have_content "0%" expect(page).to have_content "0%"
expect(page).to have_css("a.no-voted") expect(page).to have_css("a.no-voted")
end end
@@ -214,7 +214,7 @@ feature 'Votes' do
expect(page).to have_css("a.no-voted") expect(page).to have_css("a.no-voted")
end end
within('.against') do within('.against') do
expect(page).to have_content "100%" expect(page).to have_content "100%"
expect(page).to have_css("a.voted") expect(page).to have_css("a.voted")
end end
@@ -230,7 +230,7 @@ feature 'Votes' do
expect(page).to have_content "100%" expect(page).to have_content "100%"
end end
within('.against') do within('.against') do
expect(page).to have_content "0%" expect(page).to have_content "0%"
end end
@@ -250,17 +250,17 @@ feature 'Votes' do
end end
scenario 'Show' do scenario 'Show' do
vote = create(:vote, voter: @manuela, votable: @comment, vote_flag: true) create(:vote, voter: @manuela, votable: @comment, vote_flag: true)
vote = create(:vote, voter: @pablo, votable: @comment, vote_flag: false) create(:vote, voter: @pablo, votable: @comment, vote_flag: false)
visit debate_path(@debate) visit debate_path(@debate)
within("#comment_#{@comment.id}_votes") do within("#comment_#{@comment.id}_votes") do
within(".in_favor") do within(".in_favor") do
expect(page).to have_content "1" expect(page).to have_content "1"
end end
within(".against") do within(".against") do
expect(page).to have_content "1" expect(page).to have_content "1"
end end
@@ -276,7 +276,7 @@ feature 'Votes' do
expect(page).to have_content "1" expect(page).to have_content "1"
end end
within(".against") do within(".against") do
expect(page).to have_content "0" expect(page).to have_content "0"
end end
@@ -293,7 +293,7 @@ feature 'Votes' do
expect(page).to have_content "0" expect(page).to have_content "0"
end end
within('.against') do within('.against') do
expect(page).to have_content "1" expect(page).to have_content "1"
end end
@@ -310,7 +310,7 @@ feature 'Votes' do
expect(page).to have_content "1" expect(page).to have_content "1"
end end
within('.against') do within('.against') do
expect(page).to have_content "0" expect(page).to have_content "0"
end end

View File

@@ -95,7 +95,7 @@ describe Debate do
describe '#default_order' do describe '#default_order' do
let!(:economy) { create(:debate) } let!(:economy) { create(:debate) }
let!(:health) { create(:debate) } let!(:health) { create(:debate) }
it "returns debates ordered by last one first" do it "returns debates ordered by last one first" do
expect(Debate.all).to eq([health, economy]) expect(Debate.all).to eq([health, economy])

View File

@@ -1,7 +1,7 @@
require 'factory_girl_rails' require 'factory_girl_rails'
require 'database_cleaner' require 'database_cleaner'
require "email_spec" require "email_spec"
Dir["./spec/support/**/*.rb"].sort.each { |f| require f} Dir["./spec/support/**/*.rb"].sort.each { |f| require f }
RSpec.configure do |config| RSpec.configure do |config|
config.use_transactional_fixtures = false config.use_transactional_fixtures = false
@@ -17,7 +17,7 @@ RSpec.configure do |config|
end end
config.before(:each) do |example| config.before(:each) do |example|
DatabaseCleaner.strategy= example.metadata[:js] ? :truncation : :transaction DatabaseCleaner.strategy = example.metadata[:js] ? :truncation : :transaction
DatabaseCleaner.start DatabaseCleaner.start
end end