Merge pull request #4215 from consul/dependabot/bundler/rubocop-0.93.1

Bump rubocop from 0.91.1 to 0.93.1

spec/system/admin/poll/polls_spec.rb

@@ -293,7 +293,7 @@ describe "Admin polls", :admin do
 
         within("#totals") do
           within("#total_final") do
-            expect(page).to have_content("#{55555 + 63}")
+            expect(page).to have_content(55555 + 63)
           end
 
           within("#total_system") do

spec/system/admin/users_spec.rb

@@ -29,13 +29,13 @@ describe "Admin users" do
 
     visit admin_users_path
 
-    expect(page).not_to have_link("#{erased_user.id}", href: user_path(erased_user))
+    expect(page).not_to have_link(erased_user.id.to_s, href: user_path(erased_user))
     expect(page).to have_link("Erased")
 
     click_link "Erased"
 
     expect(page).to have_link("Active")
-    expect(page).to have_link("#{erased_user.id}", href: user_path(erased_user))
+    expect(page).to have_link(erased_user.id.to_s, href: user_path(erased_user))
     expect(page).to have_content "I don't like this site."
     expect(page).to have_content("Erased")
 

spec/system/budget_polls/ballot_sheets_spec.rb

@@ -26,7 +26,7 @@ describe "Poll budget ballot sheets" do
       end
 
       within("#poll_#{poll.id}") do
-        expect(page).to have_content("#{poll.name}")
+        expect(page).to have_content(poll.name)
         expect(page).to have_content("See ballot sheets list")
         expect(page).to have_content("Add results")
       end
@@ -51,7 +51,7 @@ describe "Poll budget ballot sheets" do
 
       visit officing_poll_ballot_sheets_path(poll)
 
-      expect(page).to have_content "#{poll.name}"
+      expect(page).to have_content poll.name
     end
 
     scenario "Access ballot sheets officing with multiple booth assignments", :with_frozen_time do
@@ -103,7 +103,7 @@ describe "Poll budget ballot sheets" do
     scenario "Ballot sheet is saved" do
       visit new_officing_poll_ballot_sheet_path(poll)
 
-      select "#{booth.name}", from: "officer_assignment_id"
+      select booth.name, from: "officer_assignment_id"
       fill_in "data", with: "1234;5678"
       click_button "Save"
 
@@ -119,7 +119,7 @@ describe "Poll budget ballot sheets" do
     scenario "Ballot sheet is not saved" do
       visit new_officing_poll_ballot_sheet_path(poll)
 
-      select "#{booth.name}", from: "officer_assignment_id"
+      select booth.name, from: "officer_assignment_id"
       click_button "Save"
 
       expect(page).to have_content("CSV data can't be blank")

spec/system/legislation/processes_spec.rb

@@ -155,7 +155,7 @@ describe "Legislation" do
 
         phases.each do |phase|
           within(".legislation-process-list") do
-            find("li", text: "#{phase}").click_link
+            find("li", text: phase).click_link
           end
 
           expect(page).to have_content(document.title)