Add and apply Naming/PredicateMethod RuboCop 1.76 rule
This rule was introduced in RuboCop 1.76.0 to ensure methods ending in '?' return boolean. This commit applies suggested renames and code cleanup: - Renames 'is_active?' to 'active_class' since it returns a string - Renames 'parsed_value' to 'in_favor?' and 'is_request_active' to end with '?' for boolean semantics - Skips false positives like 'save', 'auto_labels' or 'save_requiring_finish_signup', which are not predicate methods.
This commit is contained in:
@@ -35,14 +35,14 @@ class Shared::VoteButtonComponent < ApplicationComponent
|
||||
end
|
||||
|
||||
def vote
|
||||
@vote ||= Vote.find_or_initialize_by(votable: votable, voter: current_user, vote_flag: parsed_value)
|
||||
@vote ||= Vote.find_or_initialize_by(votable: votable, voter: current_user, vote_flag: in_favor?)
|
||||
end
|
||||
|
||||
def already_voted?
|
||||
vote.persisted?
|
||||
end
|
||||
|
||||
def parsed_value
|
||||
def in_favor?
|
||||
value == "yes"
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user