Use acts_as_taggable for investment valuation tags

We were manually doing the same thing, generating inconsistent results,
since the method `valuation_tag_list` was using the `valuation` context,
when actually the expected behavior would be to use the `valuation_tag`
context.
This commit is contained in:
Javi Martín
2019-10-31 20:27:20 +01:00
parent 184d5fc504
commit b8fbd6347b
11 changed files with 46 additions and 21 deletions

View File

@@ -54,7 +54,7 @@ module BudgetsHelper
end
def investment_tags_select_options(budget)
tags = budget.investments.tags_on(:valuation).order(:name).pluck(:name)
tags = budget.investments.tags_on(:valuation_tags).order(:name).pluck(:name)
tags = tags.concat budget.budget_valuation_tags.split(",") if budget.budget_valuation_tags.present?
tags.uniq
end