From b779e7903cae22fc5adc3dd63833d3cdc188e714 Mon Sep 17 00:00:00 2001 From: rgarcia Date: Thu, 10 Sep 2015 11:45:19 +0200 Subject: [PATCH] refactors letter and sms generation codes [#332] --- app/models/verification/letter.rb | 8 +++++--- app/models/verification/sms.rb | 4 ++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/app/models/verification/letter.rb b/app/models/verification/letter.rb index 3ed02677c..a64fe7220 100644 --- a/app/models/verification/letter.rb +++ b/app/models/verification/letter.rb @@ -54,8 +54,10 @@ class Verification::Letter district: address[:nombre_distrito] } end - def generate_verification_code - rand.to_s[2..7] - end + private + + def generate_verification_code + rand.to_s[2..7] + end end diff --git a/app/models/verification/sms.rb b/app/models/verification/sms.rb index f280f115e..7b032661b 100644 --- a/app/models/verification/sms.rb +++ b/app/models/verification/sms.rb @@ -24,7 +24,7 @@ class Verification::Sms end def update_user_phone_information - user.update(unconfirmed_phone: phone, sms_confirmation_code: four_digit_code) + user.update(unconfirmed_phone: phone, sms_confirmation_code: generate_confirmation_code) end def send_sms @@ -41,7 +41,7 @@ class Verification::Sms private - def four_digit_code + def generate_confirmation_code rand.to_s[2..5] end end \ No newline at end of file