From b59899e9f78c9ac63094866fbe9db224a285d889 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 3 Oct 2023 20:36:34 +0200 Subject: [PATCH] Add and apply RSpec/MetadataStyle rubocop rule This rule was introduced in rubocop-rspec 2.24.0. We were applying it most of the time. --- .rubocop.yml | 3 +++ spec/spec_helper.rb | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index a7714c1e7..7d025999a 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -564,6 +564,9 @@ RSpec/LetBeforeExamples: RSpec/LetSetup: Enabled: true +RSpec/MetadataStyle: + Enabled: true + RSpec/NotToNot: Enabled: true diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index ffe0e3cfc..a82d425e6 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -63,7 +63,7 @@ RSpec.configure do |config| Capybara.default_set_options = { clear: :backspace } end - config.before(:each, type: :system, no_js: true) do + config.before(:each, :no_js, type: :system) do driven_by :rack_test Capybara.default_set_options = {} end