consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Extract component for supporting budget admin stats

Browse Source 
This is consistent with the component for balloting stats. We're about
to change both components, and the changes are easier to follow if
they're similar.

We're also using consistent names in methods.
This commit is contained in:
Javi Martín
2023-02-06 16:35:53 +01:00
parent dd28163be7
commit b536a7cb77
6 changed files with 146 additions and 130 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
app/controllers/admin/stats_controller.rb
View File

@@ -56,19 +56,6 @@ class Admin::StatsController < Admin::BaseController
def budget_supporting
@budget = Budget.find(params[:budget_id])
heading_ids = @budget.heading_ids
votes = Vote.where(votable_type: "Budget::Investment").
includes(:budget_investment).
where(budget_investments: { heading_id: heading_ids })
@vote_count = votes.count
@user_count = votes.select(:voter_id).distinct.count
@voters_in_heading = {}
@budget.headings.each do |heading|
@voters_in_heading[heading] = voters_in_heading(heading)
end
end
def budget_balloting
@@ -85,13 +72,4 @@ class Admin::StatsController < Admin::BaseController
def sdg
@goals = SDG::Goal.order(:code)
end
private
def voters_in_heading(heading)
Vote.where(votable_type: "Budget::Investment").
includes(:budget_investment).
where(budget_investments: { heading_id: heading.id }).
select("votes.voter_id").distinct.count
end
end