consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove no-margin-bottom HTML class

Browse Source 
It was only used once, and we can use a selector that makes it obvious
where it is used. Besides, the style for the no-margin-bottom class was
to remove the bottom margin, which was inconsistent with the style for
the no-margin-top class, which adds a negative margin to the element.

I'm not sure why we're removing the margin here, though, since it isn't
consistent with the rest of the forms in the application. For now, we're
keeping it the way it used to look.
This commit is contained in:
Javi Martín
2024-03-24 16:50:24 +01:00
parent 02aac86b04
commit b3588b1865
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/stylesheets/management/account/edit_password_manually.scss
View File

@@ -1,3 +1,5 @@
.no-margin-bottom {
margin-bottom: 0 !important;
.management-account-edit-password-manually {
[type=password] {
margin-bottom: 0 !important;
}
}

4
app/components/management/account/edit_password_manually_component.html.erb
View File

@@ -1,3 +1,5 @@
<% provide :main_class, "management-account-edit-password-manually" %>
<h2 class="not-print"><%= t("management.account.menu.reset_password_manually") %></h2>
<%= form_for user, url: change_password_management_account_path do |f| %>
@@ -6,7 +8,7 @@
<div class="small-12 medium-6">
<div class="input-group">
<%= f.password_field :password, class: "input-group-field no-margin-bottom", label: false, value: nil %>
<%= f.password_field :password, class: "input-group-field", label: false, value: nil %>
<span class="input-group-label">
<a href="#" class="show-password"><span class="icon-eye"></span></a>
</span>