consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use a button to toggle proposal selection

Browse Source 
As mentioned in commit 5311daadf, using buttons for non-GET requests has
several advantages over using links.
This commit is contained in:
Javi Martín
2021-08-20 02:33:05 +02:00
parent 43b6ab00e3
commit b127bd2f51
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/system/admin/proposals_spec.rb
View File

@@ -26,13 +26,13 @@ describe "Admin proposals", :admin do
visit admin_proposals_path
within("#proposal_#{proposal.id}") { click_link "Select" }
within("#proposal_#{proposal.id}") { click_button "Select" }
within("#proposal_#{proposal.id}") { expect(page).to have_link "Selected" }
within("#proposal_#{proposal.id}") { expect(page).to have_button "Selected" }
refresh
within("#proposal_#{proposal.id}") { expect(page).to have_link "Selected" }
within("#proposal_#{proposal.id}") { expect(page).to have_button "Selected" }
end
scenario "Unselect a proposal" do
@@ -40,13 +40,13 @@ describe "Admin proposals", :admin do
visit admin_proposals_path
within("#proposal_#{proposal.id}") { click_link "Selected" }
within("#proposal_#{proposal.id}") { click_button "Selected" }
within("#proposal_#{proposal.id}") { expect(page).to have_link "Select" }
within("#proposal_#{proposal.id}") { expect(page).to have_button "Select" }
refresh
within("#proposal_#{proposal.id}") { expect(page).to have_link "Select" }
within("#proposal_#{proposal.id}") { expect(page).to have_button "Select" }
end
end