Use find instead of find_by_id

Better raise a 404 HTML NotFound exception than any other unexpected error.
This commit is contained in:
Julian Herrero
2019-01-17 10:47:54 +01:00
committed by Javi Martín
parent 22076dd95c
commit b122302c58
29 changed files with 487 additions and 33 deletions

View File

@@ -0,0 +1,25 @@
require "rails_helper"
describe Budgets::Ballot::LinesController do
describe "#load_budget" do
it "raises an error if budget slug is not found" do
controller.params[:budget_id] = "wrong_budget"
expect do
controller.send(:load_budget)
end.to raise_error ActiveRecord::RecordNotFound
end
it "raises an error if budget id is not found" do
controller.params[:budget_id] = 0
expect do
controller.send(:load_budget)
end.to raise_error ActiveRecord::RecordNotFound
end
end
end