removes empty % sign when there are no votes
This commit is contained in:
@@ -4,4 +4,8 @@ module ApplicationHelper
|
||||
debate.tag_list.map { |tag| link_to sanitize(tag), debates_path(tag: tag) }.join(', ').html_safe
|
||||
end
|
||||
|
||||
def percentage(vote, debate)
|
||||
return if debate.total_votes == 0
|
||||
debate.send(vote).percent_of(debate.total_votes).to_s + "%"
|
||||
end
|
||||
end
|
||||
|
||||
@@ -12,12 +12,6 @@ class Debate < ActiveRecord::Base
|
||||
|
||||
validates :terms_of_service, acceptance: { allow_nil: false }, on: :create
|
||||
|
||||
#vote can be 'likes' or 'dislikes'
|
||||
def percentage(vote)
|
||||
return if total_votes == 0
|
||||
send(vote).percent_of(total_votes)
|
||||
end
|
||||
|
||||
def likes
|
||||
get_likes.size
|
||||
end
|
||||
|
||||
@@ -10,12 +10,12 @@
|
||||
<div>
|
||||
<div id='in_favor'>
|
||||
<%= link_to "up", debate_votes_path(@debate, value: 'yes'), method: "post" %>
|
||||
<%= @debate.percentage('likes') %>%
|
||||
<%= percentage('likes', @debate) %>
|
||||
</div>
|
||||
|
||||
<div id='against'>
|
||||
<%= link_to "down", debate_votes_path(@debate, value: 'no'), method: "post" %>
|
||||
<%= @debate.percentage('dislikes') %>%
|
||||
<%= percentage('dislikes', @debate) %>
|
||||
</div>
|
||||
|
||||
Votos <%= @debate.total_votes %>
|
||||
|
||||
Reference in New Issue
Block a user