From afb660f82cd97bb3cdb28865f78257ea90b198d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 26 Jul 2021 22:24:50 +0200 Subject: [PATCH] Fix rubocop convention offenses While we use Pronto to detect offenses in the lines changed in our pull request, sometimes our changes introduce offenses in other lines, and we don't detect them. In commit 0488b3735, we removed the only usage of the `heading` method in a test, which caused a `RSpec/LetSetup` offense. In commit 287c48873, we changed some lines from `fill_in` to `fill_in_ckeditor`. Some of these lines were aligned with the following ones, which after that change had extra spacing for no reason. Finally, in commit 8d38ed58c we added a line before two lines which had their equals signs aligned. Since, after adding this line, the block was no longer aligned, there was no reason for the extra space in one of the lines. --- spec/system/advanced_search_spec.rb | 2 +- spec/system/budgets/investments_spec.rb | 2 +- spec/system/emails_spec.rb | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/spec/system/advanced_search_spec.rb b/spec/system/advanced_search_spec.rb index 8303f9bea..c5ee6132d 100644 --- a/spec/system/advanced_search_spec.rb +++ b/spec/system/advanced_search_spec.rb @@ -316,7 +316,7 @@ describe "Advanced search" do scenario "Search by multiple filters" do Setting["official_level_1_name"] = "Official position 1" - ana = create :user, official_level: 1 + ana = create :user, official_level: 1 john = create :user, official_level: 1 create(:budget_investment, heading: heading, title: "Get Schwifty", author: ana, created_at: 1.minute.ago) diff --git a/spec/system/budgets/investments_spec.rb b/spec/system/budgets/investments_spec.rb index 87a55a069..c4e534b11 100644 --- a/spec/system/budgets/investments_spec.rb +++ b/spec/system/budgets/investments_spec.rb @@ -531,7 +531,7 @@ describe "Budget Investments" do fill_in "Title", with: "I am a bot" fill_in_ckeditor "Description", with: "This is the description" - check "budget_investment_terms_of_service" + check "budget_investment_terms_of_service" click_button "Create Investment" diff --git a/spec/system/emails_spec.rb b/spec/system/emails_spec.rb index c617c5246..22f9173dc 100644 --- a/spec/system/emails_spec.rb +++ b/spec/system/emails_spec.rb @@ -342,9 +342,9 @@ describe "Emails" do end context "Budgets" do - let(:author) { create(:user, :level_two) } - let(:budget) { create(:budget) } - let!(:heading) { create(:budget_heading, name: "More hospitals", budget: budget) } + let(:author) { create(:user, :level_two) } + let(:budget) { create(:budget) } + before { create(:budget_heading, name: "More hospitals", budget: budget) } scenario "Investment created" do login_as(author) @@ -352,7 +352,7 @@ describe "Emails" do fill_in "Title", with: "Build a hospital" fill_in_ckeditor "Description", with: "We have lots of people that require medical attention" - check "budget_investment_terms_of_service" + check "budget_investment_terms_of_service" click_button "Create Investment" expect(page).to have_content "Investment created successfully"