From af0911a8d256cf1c3a67553eb19f3f581d32f561 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 4 Oct 2024 20:19:58 +0200 Subject: [PATCH] Fix warning in hidden proposals spec We were checking the proposal video URL, but its value was `nil` since commit bedcb5bca2. This resulted in a warning: ``` Checking for expected text of nil is confusing and/or pointless since it will always match. Please specify a string or regexp instead. spec/system/admin/hidden_proposals_spec.rb:14 ``` --- spec/factories/proposals.rb | 4 ++++ spec/system/admin/hidden_proposals_spec.rb | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/spec/factories/proposals.rb b/spec/factories/proposals.rb index 0330eeafa..3b75c707f 100644 --- a/spec/factories/proposals.rb +++ b/spec/factories/proposals.rb @@ -80,6 +80,10 @@ FactoryBot.define do after(:create) { |proposal| create(:image, imageable: proposal) } end + trait :with_video do + video_url { "https://youtu.be/nhuNb0XtRhQ" } + end + transient do voters { [] } followers { [] } diff --git a/spec/system/admin/hidden_proposals_spec.rb b/spec/system/admin/hidden_proposals_spec.rb index a022b1f8a..57d4807c2 100644 --- a/spec/system/admin/hidden_proposals_spec.rb +++ b/spec/system/admin/hidden_proposals_spec.rb @@ -2,7 +2,7 @@ require "rails_helper" describe "Admin hidden proposals", :admin do scenario "List shows all relevant info" do - proposal = create(:proposal, :hidden) + proposal = create(:proposal, :with_video, :hidden) visit admin_hidden_proposals_path expect(page).to have_content(proposal.title)