consul/nairobi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use budget phase traits

Browse Source 
We were already using them in many places, but not everywhere.
This commit is contained in:
Javi Martín
2019-09-21 16:48:35 +02:00
parent cced12c3a0
commit aeb1655961
15 changed files with 51 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/models/abilities/administrator_spec.rb
View File

@@ -76,8 +76,8 @@ describe Abilities::Administrator do
it { should be_able_to(:update, Budget::Investment) }
it { should be_able_to(:hide, Budget::Investment) }
it { should be_able_to(:valuate, create(:budget_investment, budget: create(:budget, phase: "valuating"))) }
it { should be_able_to(:valuate, create(:budget_investment, budget: create(:budget, phase: "finished"))) }
it { should be_able_to(:valuate, create(:budget_investment, budget: create(:budget, :valuating))) }
it { should be_able_to(:valuate, create(:budget_investment, budget: create(:budget, :finished))) }
it { should be_able_to(:destroy, proposal_image) }
it { should be_able_to(:destroy, proposal_document) }

8
spec/models/abilities/common_spec.rb
View File

@@ -15,10 +15,10 @@ describe Abilities::Common do
let(:own_comment) { create(:comment, author: user) }
let(:own_proposal) { create(:proposal, author: user) }
let(:accepting_budget) { create(:budget, phase: "accepting") }
let(:reviewing_budget) { create(:budget, phase: "reviewing") }
let(:selecting_budget) { create(:budget, phase: "selecting") }
let(:balloting_budget) { create(:budget, phase: "balloting") }
let(:accepting_budget) { create(:budget, :accepting) }
let(:reviewing_budget) { create(:budget, :reviewing) }
let(:selecting_budget) { create(:budget, :selecting) }
let(:balloting_budget) { create(:budget, :balloting) }
let(:investment_in_accepting_budget) { create(:budget_investment, budget: accepting_budget) }
let(:investment_in_reviewing_budget) { create(:budget_investment, budget: reviewing_budget) }

8
spec/models/abilities/everyone_spec.rb
View File

@@ -71,7 +71,7 @@ describe Abilities::Everyone do
context "when accessing budget results" do
context "budget is not finished" do
let(:budget) { create(:budget, phase: "reviewing_ballots", results_enabled: true) }
let(:budget) { create(:budget, :reviewing_ballots, results_enabled: true) }
it { should_not be_able_to(:read_results, budget) }
end
@@ -91,19 +91,19 @@ describe Abilities::Everyone do
context "when accessing budget stats" do
context "supports phase is not finished" do
let(:budget) { create(:budget, phase: "selecting", stats_enabled: true) }
let(:budget) { create(:budget, :selecting, stats_enabled: true) }
it { should_not be_able_to(:read_stats, budget) }
end
context "supports phase is finished" do
let(:budget) { create(:budget, phase: "valuating", stats_enabled: true) }
let(:budget) { create(:budget, :valuating, stats_enabled: true) }
it { should be_able_to(:read_stats, budget) }
end
context "stats disabled" do
let(:budget) { create(:budget, phase: "valuating", stats_enabled: false) }
let(:budget) { create(:budget, :valuating, stats_enabled: false) }
it { should_not be_able_to(:read_stats, budget) }
end

6
spec/models/abilities/valuator_spec.rb
View File

@@ -8,9 +8,9 @@ describe Abilities::Valuator do
let(:valuator) { create(:valuator) }
let(:group) { create(:valuator_group) }
let(:non_assigned_investment) { create(:budget_investment) }
let(:assigned_investment) { create(:budget_investment, budget: create(:budget, phase: "valuating")) }
let(:group_assigned_investment) { create(:budget_investment, budget: create(:budget, phase: "valuating")) }
let(:finished_assigned_investment) { create(:budget_investment, budget: create(:budget, phase: "finished")) }
let(:assigned_investment) { create(:budget_investment, budget: create(:budget, :valuating)) }
let(:group_assigned_investment) { create(:budget_investment, budget: create(:budget, :valuating)) }
let(:finished_assigned_investment) { create(:budget_investment, budget: create(:budget, :finished)) }
before do
assigned_investment.valuators << valuator