From adae022f77e6bac167982ffec94d94be3d98eb9a Mon Sep 17 00:00:00 2001 From: taitus Date: Tue, 19 Dec 2023 20:03:23 +0100 Subject: [PATCH] Unify can not comment as an administrator specs --- .../comments/budget_investments_spec.rb | 11 -------- spec/system/comments/debates_spec.rb | 11 -------- .../comments/legislation_annotations_spec.rb | 11 -------- .../comments/legislation_questions_spec.rb | 11 -------- spec/system/comments/polls_spec.rb | 11 -------- spec/system/comments/proposals_spec.rb | 11 -------- spec/system/comments/topics_spec.rb | 26 ------------------- spec/system/comments_spec.rb | 9 +++++++ 8 files changed, 9 insertions(+), 92 deletions(-) diff --git a/spec/system/comments/budget_investments_spec.rb b/spec/system/comments/budget_investments_spec.rb index d6bd2a097..cd661eac6 100644 --- a/spec/system/comments/budget_investments_spec.rb +++ b/spec/system/comments/budget_investments_spec.rb @@ -5,17 +5,6 @@ describe "Commenting Budget::Investments" do it_behaves_like "flaggable", :budget_investment_comment - describe "Moderators" do - scenario "can not comment as an administrator" do - moderator = create(:moderator) - - login_as(moderator.user) - visit budget_investment_path(investment.budget, investment) - - expect(page).not_to have_content "Comment as administrator" - end - end - describe "Administrators" do context "comment as administrator" do scenario "can create comment" do diff --git a/spec/system/comments/debates_spec.rb b/spec/system/comments/debates_spec.rb index 99159a7f7..f7eb0343c 100644 --- a/spec/system/comments/debates_spec.rb +++ b/spec/system/comments/debates_spec.rb @@ -125,17 +125,6 @@ describe "Commenting debates" do expect(page).to have_button "Publish comment", disabled: false end - describe "Moderators" do - scenario "can not comment as an administrator" do - moderator = create(:moderator) - - login_as(moderator.user) - visit debate_path(debate) - - expect(page).not_to have_content "Comment as administrator" - end - end - describe "Administrators" do scenario "can create comment as an administrator" do admin = create(:administrator) diff --git a/spec/system/comments/legislation_annotations_spec.rb b/spec/system/comments/legislation_annotations_spec.rb index 2806be52c..f64915438 100644 --- a/spec/system/comments/legislation_annotations_spec.rb +++ b/spec/system/comments/legislation_annotations_spec.rb @@ -20,17 +20,6 @@ describe "Commenting legislation questions" do expect(page).to have_button "Publish comment", disabled: false end - describe "Moderators" do - scenario "can not comment as an administrator" do - moderator = create(:moderator) - - login_as(moderator.user) - visit polymorphic_path(annotation) - - expect(page).not_to have_content "Comment as administrator" - end - end - describe "Administrators" do scenario "can create comment as an administrator" do admin = create(:administrator) diff --git a/spec/system/comments/legislation_questions_spec.rb b/spec/system/comments/legislation_questions_spec.rb index eff50ac1f..7d3f88641 100644 --- a/spec/system/comments/legislation_questions_spec.rb +++ b/spec/system/comments/legislation_questions_spec.rb @@ -22,17 +22,6 @@ describe "Commenting legislation questions" do expect(page).to have_button "Publish answer", disabled: false end - describe "Moderators" do - scenario "can not comment as an administrator" do - moderator = create(:moderator) - - login_as(moderator.user) - visit legislation_process_question_path(question.process, question) - - expect(page).not_to have_content "Comment as administrator" - end - end - describe "Administrators" do scenario "can create comment as an administrator" do admin = create(:administrator) diff --git a/spec/system/comments/polls_spec.rb b/spec/system/comments/polls_spec.rb index 946675637..e982571fe 100644 --- a/spec/system/comments/polls_spec.rb +++ b/spec/system/comments/polls_spec.rb @@ -4,17 +4,6 @@ describe "Commenting polls" do let(:user) { create(:user) } let(:poll) { create(:poll, author: create(:user)) } - describe "Moderators" do - scenario "can not comment as an administrator" do - moderator = create(:moderator) - - login_as(moderator.user) - visit poll_path(poll) - - expect(page).not_to have_content "Comment as administrator" - end - end - describe "Administrators" do scenario "can create comment as an administrator" do admin = create(:administrator) diff --git a/spec/system/comments/proposals_spec.rb b/spec/system/comments/proposals_spec.rb index d64e56a25..b6aa508db 100644 --- a/spec/system/comments/proposals_spec.rb +++ b/spec/system/comments/proposals_spec.rb @@ -5,17 +5,6 @@ describe "Commenting proposals" do it_behaves_like "flaggable", :proposal_comment - describe "Moderators" do - scenario "can not comment as an administrator" do - moderator = create(:moderator) - - login_as(moderator.user) - visit proposal_path(proposal) - - expect(page).not_to have_content "Comment as administrator" - end - end - describe "Administrators" do scenario "can create comment as an administrator" do admin = create(:administrator) diff --git a/spec/system/comments/topics_spec.rb b/spec/system/comments/topics_spec.rb index 608a02a71..373eea8b8 100644 --- a/spec/system/comments/topics_spec.rb +++ b/spec/system/comments/topics_spec.rb @@ -5,19 +5,6 @@ describe "Commenting topics from proposals" do it_behaves_like "flaggable", :topic_with_community_comment - describe "Moderators" do - scenario "can not comment as an administrator" do - community = proposal.community - topic = create(:topic, community: community) - moderator = create(:moderator) - - login_as(moderator.user) - visit community_topic_path(community, topic) - - expect(page).not_to have_content "Comment as administrator" - end - end - describe "Administrators" do scenario "can create comment as an administrator" do community = proposal.community @@ -180,19 +167,6 @@ describe "Commenting topics from budget investments" do let(:user) { create(:user) } let(:investment) { create(:budget_investment) } - describe "Moderators" do - scenario "can not comment as an administrator" do - community = investment.community - topic = create(:topic, community: community) - moderator = create(:moderator) - - login_as(moderator.user) - visit community_topic_path(community, topic) - - expect(page).not_to have_content "Comment as administrator" - end - end - describe "Administrators" do scenario "can create comment as an administrator" do community = investment.community diff --git a/spec/system/comments_spec.rb b/spec/system/comments_spec.rb index f51828bd2..f492db416 100644 --- a/spec/system/comments_spec.rb +++ b/spec/system/comments_spec.rb @@ -447,6 +447,15 @@ describe "Comments" do expect(page).not_to have_css "#js-comment-form-comment_#{comment.id}" end + + scenario "cannot comment as an administrator" do + moderator = create(:moderator) + + login_as(moderator.user) + visit polymorphic_path(resource) + + expect(page).not_to have_content "Comment as administrator" + end end scenario "Errors on create" do