From e71052a5f1b5372054a2a3f6ac74395bfb698466 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Fri, 24 Apr 2020 18:51:55 +0200
Subject: [PATCH] Increase severity of DynamicFindBy rubocop rule

Back in commit 49e55b4d we lowered its severity because there were a
few false positives. Back then, I didn't realize we could just whitelist
the methods causing false positives.

Thanks taitus for the tip.
---
 .rubocop.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index 8fb963919..3d300e690 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -209,7 +209,10 @@ Rails/Date:
 
 Rails/DynamicFindBy:
   Enabled: true
-  Severity: refactor
+  Whitelist:
+    - find_by_slug_or_id
+    - find_by_slug_or_id!
+    - find_by_manager_login
 
 Rails/EnumUniqueness:
   Enabled: true